1276615 - [traceback][prod] TypeError: 'NoneType' object is not iterable

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[John Giannelos [:nemo-yiannis]]

TypeError: 'NoneType' object is not iterable
  File "django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 499, in wrapper
    return wrapped(*args, **kwargs)
  File "mozillians/phonebook/views.py", line 378, in search
    return render(request, 'phonebook/search.html', d)
  File "django/shortcuts.py", line 67, in render
    template_name, context, request=request, using=using)
  File "django/template/loader.py", line 99, in render_to_string
    return template.render(context, request)
  File "django_jinja/backend.py", line 105, in render
    return self.template.render(context)
  File "newrelic/api/function_trace.py", line 98, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "jinja2/environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "jinja2/environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/data/www/mozillians.org/mozillians/mozillians/jinja2/phonebook/search.html", line 1, in top-level template code
    {% extends "base.html" %}
  File "/data/www/mozillians.org/mozillians/mozillians/jinja2/base.html", line 161, in top-level template code
    {% block content_wrapper %}
  File "/data/www/mozillians.org/mozillians/mozillians/jinja2/base.html", line 173, in block "content_wrapper"
    {% block content %}{% endblock %}
  File "/data/www/mozillians.org/mozillians/mozillians/jinja2/phonebook/search.html", line 130, in block "content"
    {% for group in functional_areas %}

Comment 1

[John Giannelos [:nemo-yiannis]]

Steps to reproduce:
* Login to mozillians.org
* Search for query="foo" limit="bar"
 * https://mozillians.org/en-US/search/?q=foo&limit=bar
* Error gets raised

Reason:
`limit` should be an int.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/ebca7a6c3a70987ab0b0148c2f42a4d60436d6f8
[Fix bug 1276615] Define `functional_areas` before rendering template

https://github.com/mozilla/mozillians/commit/63e63dfc01aff16dc6dc3d9c57bc6a22418e6e9c
Merge pull request #1458 from johngian/fix-1276615

[Fix bug 1276615] Define `functional_areas` before rendering template

Comment 3

[Tasos Katsoulas [:tasos]]

Verified on stage that the query in comment 1 does not produce any errors and returns normally.