1276643 - Tests do not fetch Widevine CDM

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

The external media tests are set up to trigger Firefox to download an up to date version of Adobe's Content Decryption Module (CDM). However the tests do not trigger this for Widevine. This results in test failures for EME protected content that uses Widevine.

As we move towards usage of Widevine CDM this will need to be remedied, so that the current tests work, and so we have coverage of Widevine.

Comment 1

[Chris Peterson [:cpeterson]]

Bryce, the external media tests run on all Firefox channels or just Nightly?

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

They currently run on Aurora and Nightly.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1276643 - External media tests reset widevine GMP.

Make the EME mixin also reset the widevine GMP. This gives us some
widevine downloader coverage, as well as meaning that EME tests that
rely on widevine should work.

Review commit: https://reviewboard.mozilla.org/r/57390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57390/

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8759388 [details]
Bug 1276643 - External media tests reset widevine GMP.

https://reviewboard.mozilla.org/r/57390/#review54390

r+wc

::: dom/media/test/external/external_media_harness/testcase.py:342
(Diff revision 1)
>              prefs_ok = self.check_and_log_boolean_pref(
>                  'media.mediasource.enabled', True)
>              prefs_ok = self.check_and_log_boolean_pref(
>                  'media.eme.enabled', True) and prefs_ok
>              prefs_ok = self.check_and_log_boolean_pref(
>                  'media.mediasource.mp4.enabled', True) and prefs_ok
>              prefs_ok = self.check_and_log_boolean_pref(
>                  'media.gmp-eme-adobe.enabled', True) and prefs_ok
>              prefs_ok = self.check_and_log_integer_pref(
>                  'media.gmp-eme-adobe.version', 1) and prefs_ok
> +            prefs_ok = self.check_and_log_boolean_pref(
> +            	'media.gmp-widevinecdm.enabled', True) and prefs_ok
> +            prefs_ok = self.chceck_and_log_version_string_pref(
> +                'media.gmp-widevinecdm.version', '1.0.0.0') and prefs_ok

This chain of `and`s can be replaced with a call to the Python built-in `all`.

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8759388 [details]
Bug 1276643 - External media tests reset widevine GMP.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57390/diff/1-2/

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8759388 [details]
Bug 1276643 - External media tests reset widevine GMP.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57390/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac2aaa6bcb4a
External media tests reset widevine GMP. r=maja_zf

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac2aaa6bcb4a

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1276643 - Correct variables used in error logging. Formatting for pep8.

Review commit: https://reviewboard.mozilla.org/r/58124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58124/

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8760551 [details]
Bug 1276643 - Correct variables used in error logging. Formatting for pep8.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58124/diff/1-2/

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8760551 [details]
Bug 1276643 - Correct variables used in error logging. Formatting for pep8.

https://reviewboard.mozilla.org/r/58124/#review55058

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/235d278e82a3
Correct variables used in error logging. Formatting for pep8. r=maja_zf

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/235d278e82a3