1276673 - Adjust |doomOnFailure| argument when calling CloseCacheEntry properly

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

The argument only has effect when we are past processing the response, the channel has been canceled, the entry is new, and the response is non-resumable.  

When set to false it apparently tries to keep entries that are non-resumable in the cache even they could potentially be partial because of premature cancellation of the loading channel.  Those are definitely 304 and redirects.


nsHttpChannel::ContinueHandleAsyncRedirect (false)
 - we can potentially end up with a non-resumable entry here, should be true

nsHttpChannel::HandleAsyncNotModified (true)
 - can be called either after response or before and we should IMO preserve the entry in the cache in what ever state it is
 - here we usually reuse an existing entry (not new) so one of the conditions to doom on true is not met anyway
 - turn to false

nsHttpChannel::OnCacheEntryAvailable (true)
 - we are definitely not past InitCacheEntry()
 - hence it has no effect and should be IMO turned to false since it just cases confusion

nsHttpChannel::ContinueBeginConnect (true)
 - called when ContinueBeginConnectWithResult returns a failure
 - the channel is definitely not past InitCacheEntry(), 
 - hence same case as OnCacheEntryAvailable -> turn to false

nsHttpChannel::OnPreflightFailed (true)
 - same case, actually this is called when ContinueConnect() is interrupted with nsCORSListenerProxy::StartCORSPreflight call
 - turn to false

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8d848ddc842

Comment 2

[Honza Bambas (:mayhemer)]

(applies over bug 1271987)

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8758364 [details] [diff] [review]
v1

Review of attachment 8758364 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86ca8a55d59e
Adjust |doomOnFailure| argument when calling CloseCacheEntry properly, r=michal

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86ca8a55d59e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86ca8a55d59e