1276676 - Remove _serializeNodeAsJSONToOutputStream

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

it is used just by a few add-ons, that should not even use it since it's an internal method.
It was kept cause it was used by Sync, but now it's no more.

Comment 1

[Akshat Kedia [:aks]]

Hi Mark, ::mak

I will like to work on this bug. Can you point me to any relevant documentation to get started on the Toolkit Module? 

Thanks,
Akshat

Comment 2

[Marco Bonardo [:mak]]

Hi, most of the stuff you need can be found here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Once you have a working build, you can write a patch (this one should be trivial since it's just code removal) and submit it through mozreview (preferred method), or make a diff and attach it directly to the bug.
If you have questions, you can ask in the #introduction channel on Mozilla IRC, or you can "needinfo" me here.

Comment 3

[Akshat Kedia [:aks]]

Attachment: MozReview Request: Bug 1276676 - Remove _serializeNodeAsJSONToOutputStream; r?:mak

Review commit: https://reviewboard.mozilla.org/r/57154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57154/

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8759061 [details]
MozReview Request: Bug 1276676 - Remove _serializeNodeAsJSONToOutputStream; r?:mak

https://reviewboard.mozilla.org/r/57154/#review54322

Thank you. In this case I don't think we need a Try run, since this is just unused code removal, so feel free to set the checkin-needed keyword.

Comment 5

[Akshat Kedia [:aks]]

https://reviewboard.mozilla.org/r/57154/#review54322

I am not sure what the issue is but if you look at the diff it shows that the "comment opening" is not removed and the "comment opening" of the comment after the removed fuction is, while that is not the case on my local machine. What am I missing here ? :/

Comment 6

[Marco Bonardo [:mak]]

(In reply to Akshat Kedia [:aks] from comment #5)
> I am not sure what the issue is but if you look at the diff it shows that
> the "comment opening" is not removed and the "comment opening" of the
> comment after the removed fuction is, while that is not the case on my local
> machine. What am I missing here ? :/

don't worry, that's just a diff artifact, it often happens. The patch is fine regardless.

Comment 7

[Akshat Kedia [:aks]]

Great, thanks Marc!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/b3a89304b903
Remove _serializeNodeAsJSONToOutputStream; r=mak

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3a89304b903