Closed Bug 1276676 Opened 8 years ago Closed 8 years ago

Remove _serializeNodeAsJSONToOutputStream

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: mak, Assigned: aks, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

it is used just by a few add-ons, that should not even use it since it's an internal method.
It was kept cause it was used by Sync, but now it's no more.
Hi Mark, ::mak

I will like to work on this bug. Can you point me to any relevant documentation to get started on the Toolkit Module? 

Thanks,
Akshat
Assignee: nobody → akshat.kedia
Status: NEW → ASSIGNED
Flags: needinfo?(mak77)
Hi, most of the stuff you need can be found here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Once you have a working build, you can write a patch (this one should be trivial since it's just code removal) and submit it through mozreview (preferred method), or make a diff and attach it directly to the bug.
If you have questions, you can ask in the #introduction channel on Mozilla IRC, or you can "needinfo" me here.
Flags: needinfo?(mak77)
Attachment #8759061 - Flags: review?(mak77)
Attachment #8759061 - Flags: review?(mak77) → review+
Comment on attachment 8759061 [details]
MozReview Request: Bug 1276676 - Remove _serializeNodeAsJSONToOutputStream; r?:mak

https://reviewboard.mozilla.org/r/57154/#review54322

Thank you. In this case I don't think we need a Try run, since this is just unused code removal, so feel free to set the checkin-needed keyword.
https://reviewboard.mozilla.org/r/57154/#review54322

I am not sure what the issue is but if you look at the diff it shows that the "comment opening" is not removed and the "comment opening" of the comment after the removed fuction is, while that is not the case on my local machine. What am I missing here ? :/
(In reply to Akshat Kedia [:aks] from comment #5)
> I am not sure what the issue is but if you look at the diff it shows that
> the "comment opening" is not removed and the "comment opening" of the
> comment after the removed fuction is, while that is not the case on my local
> machine. What am I missing here ? :/

don't worry, that's just a diff artifact, it often happens. The patch is fine regardless.
Keywords: checkin-needed
Great, thanks Marc!
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/b3a89304b903
Remove _serializeNodeAsJSONToOutputStream; r=mak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b3a89304b903
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: