Closed
Bug 1276833
Opened 9 years ago
Closed 9 years ago
[webvtt] Size should return double
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
https://w3c.github.io/webvtt/#vttcue
Now we return "long".
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57830/
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57832/
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8760116 -
Flags: review?(giles)
Attachment #8760116 -
Flags: review?(bugs)
Attachment #8760117 -
Flags: review?(giles)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.
https://reviewboard.mozilla.org/r/57830/#review54728
r+ for the webidl
Attachment #8760116 -
Flags: review?(bugs) → review+
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.
https://reviewboard.mozilla.org/r/57830/#review56056
Attachment #8760116 -
Flags: review?(giles) → review+
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8760117 [details]
Bug 1276833 - part2 : modify test.
https://reviewboard.mozilla.org/r/57832/#review56058
Attachment #8760117 -
Flags: review?(giles) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57830/diff/1-2/
|
|
Assignee | |
Comment 8•9 years ago
|
||
Comment on attachment 8760117 [details]
Bug 1276833 - part2 : modify test.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57832/diff/1-2/
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7c14498436f
part1 : size should be double. r=rillian,smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c5a862618c4
part2 : modify test. r=rillian
|
||
Comment 10•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e7c14498436f
https://hg.mozilla.org/mozilla-central/rev/6c5a862618c4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•