[webvtt] Size should return double

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

(Blocks: 1 bug)

Other Branch
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

https://w3c.github.io/webvtt/#vttcue

Now we return "long".
Created attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.

Review commit: https://reviewboard.mozilla.org/r/57830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57830/
Created attachment 8760117 [details]
Bug 1276833 - part2 : modify test.

Review commit: https://reviewboard.mozilla.org/r/57832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57832/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=221e9752f90d
Attachment #8760116 - Flags: review?(giles)
Attachment #8760116 - Flags: review?(bugs)
Attachment #8760117 - Flags: review?(giles)
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.

https://reviewboard.mozilla.org/r/57830/#review54728

r+ for the webidl
Attachment #8760116 - Flags: review?(bugs) → review+
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.

https://reviewboard.mozilla.org/r/57830/#review56056
Attachment #8760116 - Flags: review?(giles) → review+
Comment on attachment 8760117 [details]
Bug 1276833 - part2 : modify test.

https://reviewboard.mozilla.org/r/57832/#review56058
Attachment #8760117 - Flags: review?(giles) → review+
Comment on attachment 8760116 [details]
Bug 1276833 - part1 : size should be double.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57830/diff/1-2/
Comment on attachment 8760117 [details]
Bug 1276833 - part2 : modify test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57832/diff/1-2/

Comment 9

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7c14498436f
part1 : size should be double. r=rillian,smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c5a862618c4
part2 : modify test. r=rillian

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e7c14498436f
https://hg.mozilla.org/mozilla-central/rev/6c5a862618c4
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.