1276838 - Improve ergonomics for cubeb function calls for AudioStream

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Cubeb function must be called without lock held to avoid deadlock. Therefore we used to have code like:

int r;
{
  MonitorAutoUnlock mon(mMonitor);
  r = cubeb_stream_xxx();
}
// do something about the return value |r|.

This style is a bit ugly. We can do something instead:

int r = InvokeCubebFunction();
// do something about the return value |r|.

InvokeCubebFunction will release the monitor before calling cubeb functions.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1276838 - improve coding style of calling cubeb functions. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/56492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56492/

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8758126 [details]
MozReview Request: Bug 1276838 - improve coding style of calling cubeb functions. r=kinetik.

https://reviewboard.mozilla.org/r/56492/#review53082

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/373e67c2caad
improve coding style of calling cubeb functions. r=kinetik.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/373e67c2caad