1276849 - Some AudioStream::OpenCubeb() code cleanup

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Since OpenCubeb() is always called synchronously inside Init(), we won't continue using an object should Init() fail. Therefore OpenCubeb() can just return an error without setting mState to ERRORED.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=048f434e3953

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1276849 - some AudioStream::OpenCubeb code cleanup. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/56820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56820/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/56820/#review53524

::: dom/media/AudioStream.cpp
(Diff revision 1)
>                    const dom::AudioChannel aAudioChannel)
>  {
>    auto startTime = TimeStamp::Now();
>    mIsFirst = CubebUtils::GetFirstStream();
>  
> -  if (!CubebUtils::GetCubebContext()) {

OpenCubeb() will call that.

::: dom/media/AudioStream.cpp
(Diff revision 1)
> -      NS_WARNING(nsPrintfCString("AudioStream::OpenCubeb() %p failed to init cubeb", this).get());
> +    NS_WARNING(nsPrintfCString("AudioStream::OpenCubeb() %p failed to init cubeb", this).get());
> -      return NS_ERROR_FAILURE;
> +    return NS_ERROR_FAILURE;
> -    }
> +  }
> -  }
> -
> -  mState = INITIALIZED;

mState is already INITIALIZED. No need to set it again.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8758564 [details]
MozReview Request: Bug 1276849 - some AudioStream::OpenCubeb code cleanup. r=kinetik.

https://reviewboard.mozilla.org/r/56820/#review53530

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/408312a8ef14
some AudioStream::OpenCubeb code cleanup. r=kinetik.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/408312a8ef14