Closed Bug 1276852 Opened 4 years ago Closed 4 years ago

Add assertions to AudioStream::Start()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Since OpenCubeb() is always called synchronously inside Init(), we can assert Start() should be called when mState is INITIALIZED.
Assignee: nobody → jwwang
Blocks: 1274160
Also thanks to bug 1276840, DataCallback() will no longer change mState. We don't need to set mState to STARTED before calling cubeb_stream_start.
Comment on attachment 8758567 [details]
MozReview Request: Bug 1276852 - Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.

https://reviewboard.mozilla.org/r/56828/#review53536
Attachment #8758567 - Flags: review?(kinetik) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2bd91854be
Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.
https://hg.mozilla.org/mozilla-central/rev/bc2bd91854be
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.