1276852 - Add assertions to AudioStream::Start()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Since OpenCubeb() is always called synchronously inside Init(), we can assert Start() should be called when mState is INITIALIZED.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Also thanks to bug 1276840, DataCallback() will no longer change mState. We don't need to set mState to STARTED before calling cubeb_stream_start.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1276852 - Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/56828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56828/

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8758567 [details]
MozReview Request: Bug 1276852 - Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.

https://reviewboard.mozilla.org/r/56828/#review53536

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2bd91854be
Assert AudioStream::Start() is called when mState is INITIALIZED. r=kinetik.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bc2bd91854be