1276865 - Set autoJSAPIOwnsErrorReporting when initializing the self-hosting compartment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Self-hosting initialization uses its own error reporter. We want to use the reporter only for warnings, and propagate exceptions up to the caller.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8758143 [details] [diff] [review]
Patch

Review of attachment 8758143 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, nice.

::: js/src/vm/SelfHosting.cpp
@@ +2686,5 @@
>      return shg;
>  }
>  
> +static void
> +PrintAndClearPendingException(JSContext* cx, FILE* file)

Perhaps call this "MaybePrint..."? We have js::GetAndClearException which asserts that an exception is pending, and it seems like we should align with that behavior, or make it clear that this does something different.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa6261dbb77
Set autoJSAPIOwnsErrorReporting when initializing the self-hosting compartment. r=till

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3aa6261dbb77