1276876 - Migrate the ruleview Image & Font preview to use HTML Tooltip

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P1)

Description

[Julian Descottes [:jdescottes]]

The goal of this bug is to migrate the previewTooltip of the TooltipsOverlay class to a HTMLTooltip instance.

We will need to migrate two helper functions to be use the HTMLToolip:
- setRelativeImageContent
- setFontFamilyContent
(these 2 methods are used only here, so no need to keep a XUL Tooltip version alive)

This is very similar to what was done for the markup-view image preview migration.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

Review commit: https://reviewboard.mozilla.org/r/56928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56928/

Comment 2

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a969744500da

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8758742 [details]
MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56928/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bebc9d871f

Comment 5

[Julian Descottes [:jdescottes]]

Try seems green so far, the browser_dbg_search-symbols.js failures are linked to a bad commit that was backed out a bit later (see https://hg.mozilla.org/integration/fx-team/rev/08084e9e30d2)

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8758742 [details]
MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

https://reviewboard.mozilla.org/r/56928/#review54134

Thank you.  This looks good to me.

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the review Tom!

Try is green, landing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/46d41d717dde
ruleview: migrate font&image preview tooltips to HTMLTooltips;r=tromey

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46d41d717dde

Comment 10

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to test this bug on Firefox 50.0a1 (2016-06-07) across platforms[1].
Beside the already known issues (Bug 932220, Bug 1067999, Bug 938097), I noticed that the Font preview text is wrongly displayed when the FF window width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the text can't be displayed entirely, than the first part of the text should be displayed instead of the middle part.
Note that the issue describe above is not reproducible if the 'Dock to side of browser window' option is enabled.
Should I log a new bug for this issue?

[1] Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.5.

Comment 11

[Julian Descottes [:jdescottes]]

(In reply to Mihai Boldan, QA [:mboldan] from comment #10)
> I managed to test this bug on Firefox 50.0a1 (2016-06-07) across
> platforms[1].
> Beside the already known issues (Bug 932220, Bug 1067999, Bug 938097), I
> noticed that the Font preview text is wrongly displayed when the FF window
> width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the
> text can't be displayed entirely, than the first part of the text should be
> displayed instead of the middle part.
> Note that the issue describe above is not reproducible if the 'Dock to side
> of browser window' option is enabled.
> Should I log a new bug for this issue?
> 
> [1] Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.5.

Thanks for spotting this Mihai, I think it's a valid issue and we should log a Bug for this.

> width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the
> text can't be displayed entirely, than the first part of the text should be
> displayed instead of the middle part.

Resizing the font-preview image to fit the tooltip could also be acceptable.

Comment 12

[Mihai Boldan, Desktop QA [:mboldan]]

I logged Bug 1279189 for the issue described in Comment 11.
Since the found issues were logged separately, I am marking this issue Verified Fixed.