Migrate the ruleview Image & Font preview to use HTML Tooltip

VERIFIED FIXED in Firefox 49

Status

()

Firefox
Developer Tools: CSS Rules Inspector
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

Trunk
Firefox 49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed, firefox50 verified)

Details

(Whiteboard: [devtools-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The goal of this bug is to migrate the previewTooltip of the TooltipsOverlay class to a HTMLTooltip instance.

We will need to migrate two helper functions to be use the HTMLToolip:
- setRelativeImageContent
- setFontFamilyContent
(these 2 methods are used only here, so no need to keep a XUL Tooltip version alive)

This is very similar to what was done for the markup-view image preview migration.
(Assignee)

Updated

a year ago
Blocks: 1259121
Flags: qe-verify+
Whiteboard: [devtools-html]
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] → [devtools-html] [triage]
(Assignee)

Updated

a year ago
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
Created attachment 8758742 [details]
MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

Review commit: https://reviewboard.mozilla.org/r/56928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56928/
(Assignee)

Comment 2

a year ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a969744500da
(Assignee)

Updated

a year ago
Blocks: 1277264
Iteration: --- → 49.3 - Jun 6
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
(Assignee)

Comment 3

a year ago
Comment on attachment 8758742 [details]
MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56928/diff/1-2/
Attachment #8758742 - Attachment description: MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips → MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey
Attachment #8758742 - Flags: review?(ttromey)
(Assignee)

Comment 4

a year ago
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bebc9d871f
(Assignee)

Comment 5

a year ago
Try seems green so far, the browser_dbg_search-symbols.js failures are linked to a bad commit that was backed out a bit later (see https://hg.mozilla.org/integration/fx-team/rev/08084e9e30d2)

Comment 6

a year ago
Comment on attachment 8758742 [details]
MozReview Request: Bug 1276876 - ruleview: migrate font&image preview tooltips to HTMLTooltips;r?tromey

https://reviewboard.mozilla.org/r/56928/#review54134

Thank you.  This looks good to me.
Attachment #8758742 - Flags: review?(ttromey) → review+
(Assignee)

Comment 7

a year ago
Thanks for the review Tom!

Try is green, landing.

Comment 8

a year ago
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/46d41d717dde
ruleview: migrate font&image preview tooltips to HTMLTooltips;r=tromey
(Assignee)

Updated

a year ago
Depends on: 1277906

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/46d41d717dde
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
I managed to test this bug on Firefox 50.0a1 (2016-06-07) across platforms[1].
Beside the already known issues (Bug 932220, Bug 1067999, Bug 938097), I noticed that the Font preview text is wrongly displayed when the FF window width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the text can't be displayed entirely, than the first part of the text should be displayed instead of the middle part.
Note that the issue describe above is not reproducible if the 'Dock to side of browser window' option is enabled.
Should I log a new bug for this issue?

[1] Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.5.
QA Whiteboard: [qe-dthtml]
Flags: needinfo?(jdescottes)
(Assignee)

Comment 11

a year ago
(In reply to Mihai Boldan, QA [:mboldan] from comment #10)
> I managed to test this bug on Firefox 50.0a1 (2016-06-07) across
> platforms[1].
> Beside the already known issues (Bug 932220, Bug 1067999, Bug 938097), I
> noticed that the Font preview text is wrongly displayed when the FF window
> width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the
> text can't be displayed entirely, than the first part of the text should be
> displayed instead of the middle part.
> Note that the issue describe above is not reproducible if the 'Dock to side
> of browser window' option is enabled.
> Should I log a new bug for this issue?
> 
> [1] Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.10.5.

Thanks for spotting this Mihai, I think it's a valid issue and we should log a Bug for this.

> width is reduced (http://imgur.com/Uac7sV8). As an expected result, if the
> text can't be displayed entirely, than the first part of the text should be
> displayed instead of the middle part.

Resizing the font-preview image to fit the tooltip could also be acceptable.
Flags: needinfo?(jdescottes)
Depends on: 1279189
I logged Bug 1279189 for the issue described in Comment 11.
Since the found issues were logged separately, I am marking this issue Verified Fixed.
Status: RESOLVED → VERIFIED
status-firefox50: --- → verified
Flags: qe-verify+
(Assignee)

Updated

a year ago
Duplicate of this bug: 932317
You need to log in before you can comment on or make changes to this bug.