Closed Bug 1276879 Opened 8 years ago Closed 8 years ago

Convert jsapi-tests to autoJSAPIOwnsErrorReporting

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
This is also much nicer. Tests can just get the pending exception instead of registering an error handler and setting a global variable there.
Attachment #8758172 - Flags: review?(jorendorff)
Blocks: 1277278
Attachment #8758172 - Flags: review?(jorendorff) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82bf2f128bfb
Convert jsapi-tests to autoJSAPIOwnsErrorReporting. r=jorendorff
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b77e05bf69d5
followup - Use JS::RootedValue instead of RootedValue to fix non-unified build. r=bustage
https://hg.mozilla.org/mozilla-central/rev/82bf2f128bfb
https://hg.mozilla.org/mozilla-central/rev/b77e05bf69d5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: