Closed Bug 1276904 Opened 3 years ago Closed 3 years ago

container-icon is shown when a container tab is opened in background.

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

Attached patch icon.patch (obsolete) — Splinter Review
STR: Right click on a link -> Open in a container tab -> Choose a container.
A new container tab is opened, but its icon is shown in the current tab.
Attachment #8758222 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8758222 [details] [diff] [review]
icon.patch

Review of attachment 8758222 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +4327,5 @@
>                if (tab && data.userContextId) {
>                  tab.setUserContextId(data.userContextId);
>                }
>  
> +              updateUserContextUIIndicator(gBrowser.selectedBrowser);

This doesn't make sense. For one, a link opened in another tab might not be selected. For another, we're updating the browser's tab's user context ID, and then updating the UI for what is presumably a different browser object. That doesn't make sense - we should be updating the data and the UI for the same browser.
Attachment #8758222 - Flags: review?(gijskruitbosch+bugs) → review-
Attached patch icon.patchSplinter Review
Attachment #8758222 - Attachment is obsolete: true
Attachment #8758258 - Flags: review?(gijskruitbosch+bugs)
Attachment #8758258 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbf056a4231e
container-icon visibility should follow the selectedBrowser, r=gijs
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
https://hg.mozilla.org/mozilla-central/rev/fbf056a4231e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.