Hide "Add to home screen" in private browsing

RESOLVED FIXED in Firefox 48

Status

()

--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TeoVermesan, Assigned: sebastian)

Tracking

49 Branch
Firefox 49
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8758230 [details]
Screenshot_2016-05-31-11-45-32.png

Steps to reproduce:
1. Visit a site several times in private browsing 

Expected results:
- "Add to home screen" notification is displayed

Actual results:
- Don't show "Add to home screen" in private browsing
This feature should be disabled, but I agree this is a valid bug we would want to prevent from happening if we're going to ship this feature.
Blocks: 1232706
(Assignee)

Updated

3 years ago
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
Created attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Review commit: https://reviewboard.mozilla.org/r/56860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56860/
Attachment #8758606 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Approval Request Comment

[Feature/regressing bug #]: "Add to home screen" is an experiment that is enabled in Nightly and Aurora. As this code rides the trains we want to enable it in Beta too to get more data (Bug 1277180).

[User impact if declined]: Without this patch we potentially show this prompt in private browsing too. This is something we do not want. So this would block enabling this in Beta.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Very low. This patch just checks if the tab is private and if so doesn't execute the "Add to home screen" code.

[String/UUID change made/needed]: -
Attachment #8758606 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

3 years ago
status-firefox48: --- → affected
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

https://reviewboard.mozilla.org/r/56860/#review53602
Attachment #8758606 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/faa1661edc002da6a574b08a4b24c9a55f29e6d3
Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/faa1661edc00
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Make sense, taking it
Attachment #8758606 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
has problems to apply to aurora :

grafting 347866:faa1661edc00 "Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret"
merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 9

3 years ago
Created attachment 8760164 [details] [diff] [review]
1276910-prompt-private-tab-AURORA.patch

Modified patch for Aurora.
Flags: needinfo?(s.kaspari) → needinfo?(cbook)
https://hg.mozilla.org/releases/mozilla-aurora/rev/55772f8675f3
status-firefox48: affected → fixed
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.