Closed
Bug 1276910
Opened 9 years ago
Closed 9 years ago
Hide "Add to home screen" in private browsing
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: TeoVermesan, Assigned: sebastian)
References
Details
Attachments
(3 files)
215.84 KB,
image/png
|
Details | |
58 bytes,
text/x-review-board-request
|
Margaret
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
1.34 KB,
patch
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Visit a site several times in private browsing
Expected results:
- "Add to home screen" notification is displayed
Actual results:
- Don't show "Add to home screen" in private browsing
Comment 1•9 years ago
|
||
This feature should be disabled, but I agree this is a valid bug we would want to prevent from happening if we're going to ship this feature.
Blocks: 1232706
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56860/
Attachment #8758606 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret
Approval Request Comment
[Feature/regressing bug #]: "Add to home screen" is an experiment that is enabled in Nightly and Aurora. As this code rides the trains we want to enable it in Beta too to get more data (Bug 1277180).
[User impact if declined]: Without this patch we potentially show this prompt in private browsing too. This is something we do not want. So this would block enabling this in Beta.
[Describe test coverage new/current, TreeHerder]: Local testing.
[Risks and why]: Very low. This patch just checks if the tab is private and if so doesn't execute the "Add to home screen" code.
[String/UUID change made/needed]: -
Attachment #8758606 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
status-firefox48:
--- → affected
Comment 4•9 years ago
|
||
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret
https://reviewboard.mozilla.org/r/56860/#review53602
Attachment #8758606 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/faa1661edc002da6a574b08a4b24c9a55f29e6d3
Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret
Comment 6•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 7•9 years ago
|
||
Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret
Make sense, taking it
Attachment #8758606 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•9 years ago
|
||
has problems to apply to aurora :
grafting 347866:faa1661edc00 "Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret"
merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(s.kaspari)
Assignee | ||
Comment 9•9 years ago
|
||
Modified patch for Aurora.
Flags: needinfo?(s.kaspari) → needinfo?(cbook)
Comment 10•9 years ago
|
||
Flags: needinfo?(cbook)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•