1276910 - Hide "Add to home screen" in private browsing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2016-05-31-11-45-32.png

Steps to reproduce:
1. Visit a site several times in private browsing 

Expected results:
- "Add to home screen" notification is displayed

Actual results:
- Don't show "Add to home screen" in private browsing

Comment 1

[:Margaret Leibovic]

This feature should be disabled, but I agree this is a valid bug we would want to prevent from happening if we're going to ship this feature.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Review commit: https://reviewboard.mozilla.org/r/56860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56860/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Approval Request Comment

[Feature/regressing bug #]: "Add to home screen" is an experiment that is enabled in Nightly and Aurora. As this code rides the trains we want to enable it in Beta too to get more data (Bug 1277180).

[User impact if declined]: Without this patch we potentially show this prompt in private browsing too. This is something we do not want. So this would block enabling this in Beta.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Very low. This patch just checks if the tab is private and if so doesn't execute the "Add to home screen" code.

[String/UUID change made/needed]: -

Comment 4

[:Margaret Leibovic]

Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

https://reviewboard.mozilla.org/r/56860/#review53602

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/faa1661edc002da6a574b08a4b24c9a55f29e6d3
Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/faa1661edc00

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8758606 [details]
MozReview Request: Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r?margaret

Make sense, taking it

Comment 8

[Carsten Book [:Tomcat]]

has problems to apply to aurora :

grafting 347866:faa1661edc00 "Bug 1276910 - Do not show "Add to home screen" prompt in private browsing. r=margaret"
merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1276910-prompt-private-tab-AURORA.patch

Modified patch for Aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55772f8675f3