1276919 - TileExpiry can use the observer service off the main thread

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Josh Matthews [:jdm]]

This is the cause of the majority of crashes reported at https://crash-stats.mozilla.com/search/?product=Firefox&moz_crash_reason=%3DMOZ_CRASH%28Using%20observer%20service%20off%20the%20main%20thread%21%29&moz_crash_reason=%3DMOZ_CRASH%28Using%20observer%20service%20off%20the%20main%20thread%21%29&_facets=moz_crash_reason&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=moz_crash_reason#crash-reports .

For example: https://crash-stats.mozilla.com/report/index/2fe41184-e603-421c-a036-b95092160524

I'm not entirely sure how to read the stack in that report (which is much more readable than many others I came across), since we appear to finalize sTileExpiry under glTexSubImage2d. It seems clear that sTileExpiry can be destroyed off the main thread, however, and that invokes nsExpirationTracker's destructor which calls RemoveObserver.

Comment 1

[Benoit Girard (:BenWa)]

Good find.

Ernest can you have a look? Let me know if you have any questions.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'nsObserverService::RemoveObserver':
 - nightly (version 50): 4 crashes from 2016-06-06.
 - aurora  (version 49): 6 crashes from 2016-06-07.
 - beta    (version 48): 24 crashes from 2016-06-06.
 - release (version 47): 154 crashes from 2016-05-31.
 - esr     (version 45): 9 crashes from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          2          1          0          0          0
 - aurora           2          0          0          0          1          2          0
 - beta             2          3          5          2          5          4          1
 - release         25         28         20         28         24         19          5
 - esr              0          1          2          1          1          0          1

Affected platforms: Windows, Mac OS X

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'nsObserverService::RemoveObserver':
 - nightly (version 51): 1 crash from 2016-08-01.
 - aurora  (version 50): 25 crashes from 2016-08-01.
 - beta    (version 49): 27 crashes from 2016-08-02.
 - release (version 48): 32 crashes from 2016-07-25.
 - esr     (version 45): 10 crashes from 2016-05-02.

Crash volume on the last weeks (Week N is from 08-22 to 08-28):
            W. N-1  W. N-2  W. N-3
 - nightly       0       0       0
 - aurora        8      12       1
 - beta          8      12       3
 - release      14       5       4
 - esr           0       0       0

Affected platforms: Windows, Mac OS X

Crash rank on the last 7 days:
           Browser     Content   Plugin
 - nightly #879
 - aurora  #342
 - beta    #2023
 - release #1272
 - esr     #5472

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 5

[Gabriele Svelto [:gsvelto]]

This was due to a signature change but that's OK. There were at least three different bugs behind this signature so I'll file separate bugs for each of them instead of reopening this one.