1277037 - MOZ_CRASH: Could not start cubeb stream for MSG.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Ralph Giles (:rillian)]

Crash reporter shows a few failures of AudioCallbackDriver::StartStream(). This is only called from the fallible AsyncCubebTask::Run(), so plumbing through a error return seems reasonable.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1277037 - Make AudioCallbackDriver::StartStream fallible.

Avoid crashing in the case that cubeb stream start fails and report
an error instead.

Review commit: https://reviewboard.mozilla.org/r/56660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56660/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8758435 [details]
Bug 1277037 - Make AudioCallbackDriver::StartStream fallible.

https://reviewboard.mozilla.org/r/56660/#review53506

Ok, though I wish I knew which HW/drivers were crashing (can you add a search link to the bug for the reports?, though I doubt they tell us much)

Comment 3

[Ralph Giles (:rillian)]

Sorry, a crash report example is https://crash-stats.mozilla.com/report/index/cfffb88d-f60d-41c8-812f-d23302160601 found from the general MOZ_CRASH search from the dev-platform thread. i.e. https://is.gd/9eqQB3

As you might expect the stack trace isn't enlightening. I don't see a way to get audio driver info in the crash reports; it has been off-and-on since firefox 36 at least, and off again since 47.

Try push wasn't green. Investigating whether the timeouts are caused by this patch somehow.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8758435 [details]
Bug 1277037 - Make AudioCallbackDriver::StartStream fallible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56660/diff/1-2/

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8758435 [details]
Bug 1277037 - Make AudioCallbackDriver::StartStream fallible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56660/diff/2-3/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8758435 [details]
Bug 1277037 - Make AudioCallbackDriver::StartStream fallible.

https://reviewboard.mozilla.org/r/56660/#review104668

::: dom/media/GraphDriver.cpp:648
(Diff revision 3)
>    if (latencyPref) {
>      latency_frames = latencyPref.value();
>    } else {
>      if (cubeb_get_min_latency(cubebContext, output, &latency_frames) != CUBEB_OK) {
>        NS_WARNING("Could not get minimal latency from cubeb.");
> -      return;
> +      return false;

Oops, looks like I forgot to land this. I still see crashes with FF 50 and 52, so rebased on top of subsequent changes and added another failure return here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/150548e72f33
Make AudioCallbackDriver::StartStream fallible. r=jesup

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/150548e72f33