1277063 - [wasm] Update WebAssembly pilot format to support semicolons and parens

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Yury Delendik (:yury)]

Based on new update to the grammar (see [1]) few items needs to be changed:

- Add semicolons (after each drop value statement?).
- Add parenthesis for every operation that is not expressed as ASCII-art operator.
- Change load and store operations to be array-like.

  [1] https://github.com/sunfishcode/design/commit/0141d6420bba8b47ac15943a9d670f0516ec85fc#diff-fd84284c66f9d51232ae21604e3e4d4b

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1277063 - Update WebAssembly pilot format to support semicolons and parens.

Review commit: https://reviewboard.mozilla.org/r/56788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56788/

Comment 2

[Yury Delendik (:yury)]

(Also includes fixes for indenture, missing parens, and test for operator precedence)

Comment 3

[Dan Gohman [:sunfish]]

Comment on attachment 8758514 [details]
Bug 1277063 - Update WebAssembly pilot format to support semicolons and parens.

https://reviewboard.mozilla.org/r/56788/#review53688

Looks good.

One additional tweak request: Could you add a space after the ":" in PrintSignature and PrintFunction when they're printing arguments and locals? It's not syntactically significant, but it is the prevalent style in TypeScript, which the current type syntax is trying to resemble somewhat. Eg. "x: i32" rather than "x:i32".

Comment 4

[Yury Delendik (:yury)]

Comment on attachment 8758514 [details]
Bug 1277063 - Update WebAssembly pilot format to support semicolons and parens.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56788/diff/1-2/

Comment 5

[Yury Delendik (:yury)]

Comment on attachment 8758514 [details]
Bug 1277063 - Update WebAssembly pilot format to support semicolons and parens.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56788/diff/2-3/

Comment 6

[Dan Gohman [:sunfish]]

The updates look good to me. We might also want a space after the "," now, but I'm ok addressing that in a followup if you prefer.

Comment 7

[Yury Delendik (:yury)]

Comment on attachment 8758514 [details]
Bug 1277063 - Update WebAssembly pilot format to support semicolons and parens.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56788/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71530f6566b9
Update WebAssembly pilot format to support semicolons and parens. r=sunfish

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71530f6566b9