Closed
Bug 1277089
Opened 8 years ago
Closed 8 years ago
Separate room join/refresh functions into a new store
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: dcritchley)
References
()
Details
(Whiteboard: [akita-alpha])
User Story
Tech Checklist: - Create a new shared store, e.g. "serverConnectionStore" - Move the Rooms:Join request from activeRoomStore#gotMediaPermission into the new store in a gotMediaPermission action function. - Move the Rooms:Refresh request and related functions from activeRoomStore into the new store (probably keep names the same). - Create instances of the new store in webapp.jsx & sidebar.jsx If possible, ignore the "HangupNow" function for the time being.
Attachments
(1 file)
See user story for details. This is part of the work of separating out joining a room on the loop-server from the WebRTC code. The UX flow will remain the same in this bug.
|
Reporter | |
Updated•8 years ago
|
Blocks: akita-non-feature
Rank: 11
|
|
Reporter | |
Comment 1•8 years ago
|
||
WIP almost complete branch is here: https://github.com/daveccrit/loop/tree/1277089-SeparateRoomJoin
|
||
Comment 2•8 years ago
|
||
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8760417 [details] [review] [loop] daveccrit:1277089-SeparateRoomJoin > mozilla:akita r=Standard8. Mainly paired on this, also reviewed fully by me.
Attachment #8760417 -
Flags: review+
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•