Closed Bug 1277107 Opened 3 years ago Closed 2 years ago

Intermittent browser_UITour_heartbeat.js | Heartbeat should appear in the most recent private window - Got false, expected true

Categories

(Firefox :: Tours, defect)

49 Branch
defect
Not set

Tracking

()

RESOLVED INCOMPLETE
Tracking Status
firefox48 --- unaffected
firefox49 --- disabled
firefox50 --- disabled
firefox51 --- disabled

People

(Reporter: KWierso, Unassigned)

References

Details

(Keywords: intermittent-failure)

Alessio, any idea why this might have gone of the rails in the last few days?
Flags: needinfo?(alessio.placitelli)
(In reply to Ryan VanderMeulen [:RyanVM] (Away June 4-20) from comment #2)
> Alessio, any idea why this might have gone of the rails in the last few days?

Mh, I'm afraid not. What I can think of is that we're not receiving something that makes |promisePageEvent| [1] resolve earlier.

Unfortunately I can't investigate this further right now. I will probably be able to in a couple of weeks. 

[1] - https://dxr.mozilla.org/mozilla-central/rev/3e8ee3599a67edd971770af4982ad4b0fe77f073/browser/components/uitour/test/browser_UITour_heartbeat.js#597
Flags: needinfo?(alessio.placitelli)
This could be related to bug 1264108 as well.
This is awful.
Flags: needinfo?(alessio.placitelli)
Quite awful.
Whiteboard: [test disabled on Windows]
Keywords: leave-open
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6020555323
Skip browser_UITour_heartbeat.js on Windows where it fails constantly
Flags: needinfo?(alessio.placitelli)
Priority: -- → P2
Whiteboard: [test disabled on Windows] → [test disabled on Windows][measurement:client]
(In reply to Ryan VanderMeulen [:RyanVM] from comment #27)
> This is awful.

Yeah, quite awful. I took a quick look at the problem and seems to point to a real bug, on Windows.
I can reproduce the behaviour on Windows 10: if you run the test and then click elsewhere on the desktop, Heartbeat will fail to show in the most recent private window.

This happens because [1] returns null due to [2] not returning all the opened browser windows (in the specific case of the test, it only returns the top-most non private window).

I can't dig deeper into the issue due to time.

@Gregg, does your team have any engineer who can take it from there? Or, better, who owns that part? :-)

[1] - https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/browser/components/uitour/UITour.jsm#410
[2] - https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/browser/modules/RecentWindow.jsm#58
Flags: needinfo?(glind)
I claim this is a MattN, will NI him.
Flags: needinfo?(glind) → needinfo?(MattN+bmo)
Priority: P2 → P3
Priority: P3 → --
Whiteboard: [test disabled on Windows][measurement:client]
test doesn't exist in tree anymore
Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: leave-open
Resolution: --- → INCOMPLETE
Flags: needinfo?(MattN+bmo)
You need to log in before you can comment on or make changes to this bug.