Closed Bug 1277107 Opened 3 years ago Closed 2 years ago
_UITour _heartbeat .js | Heartbeat should appear in the most recent private window - Got false, expected true
Alessio, any idea why this might have gone of the rails in the last few days?
(In reply to Ryan VanderMeulen [:RyanVM] (Away June 4-20) from comment #2) > Alessio, any idea why this might have gone of the rails in the last few days? Mh, I'm afraid not. What I can think of is that we're not receiving something that makes |promisePageEvent|  resolve earlier. Unfortunately I can't investigate this further right now. I will probably be able to in a couple of weeks.  - https://dxr.mozilla.org/mozilla-central/rev/3e8ee3599a67edd971770af4982ad4b0fe77f073/browser/components/uitour/test/browser_UITour_heartbeat.js#597
This could be related to bug 1264108 as well.
This is awful.
Whiteboard: [test disabled on Windows]
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b6020555323 Skip browser_UITour_heartbeat.js on Windows where it fails constantly
Priority: -- → P2
Whiteboard: [test disabled on Windows] → [test disabled on Windows][measurement:client]
(In reply to Ryan VanderMeulen [:RyanVM] from comment #27) > This is awful. Yeah, quite awful. I took a quick look at the problem and seems to point to a real bug, on Windows. I can reproduce the behaviour on Windows 10: if you run the test and then click elsewhere on the desktop, Heartbeat will fail to show in the most recent private window. This happens because  returns null due to  not returning all the opened browser windows (in the specific case of the test, it only returns the top-most non private window). I can't dig deeper into the issue due to time. @Gregg, does your team have any engineer who can take it from there? Or, better, who owns that part? :-)  - https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/browser/components/uitour/UITour.jsm#410  - https://dxr.mozilla.org/mozilla-central/rev/0502bd9e025edde29777ba1de4280f9b52af4663/browser/modules/RecentWindow.jsm#58
I claim this is a MattN, will NI him.
Flags: needinfo?(glind) → needinfo?(MattN+bmo)
Priority: P3 → --
Whiteboard: [test disabled on Windows][measurement:client]
test doesn't exist in tree anymore
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.