Closed Bug 1277136 Opened 7 years ago Closed 7 years ago

Reset GMP script should run in content context

Categories

(Testing Graveyard :: external-media-tests, defect)

Product:
Testing Graveyard
Component:
external-media-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(1 file)

MozReview Request: Bug 1277136 - External Media Tests: Fix typos, update context usage, update gmp reset script. r?maja_zf
58 bytes, text/x-review-board-request
impossibus
: review+
Details 
The script in EMESetupMixin (https://dxr.mozilla.org/mozilla-central/source/dom/media/test/external/external_media_harness/testcase.py#214) that resets GMP is currently being called in the chrome context. This needs to be done in the content context so that the appropriate handlers are notified.
Assignee: nobody → bvandyk
- Fix a typo in media.gmp-eme-adobe.version pref strings.
- Update reset gmp script call to be from content context. This
would fail if done from the chrome process.
- Update reset gmp script to use new requestMediaKeySystemAccess
syntax.

Review commit: https://reviewboard.mozilla.org/r/56796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56796/
Attachment #8758521 - Flags: review?(mjzffr)
Summary: Reset GMP script should run on context thread → Reset GMP script should run in content context
Comment on attachment 8758521 [details]
MozReview Request: Bug 1277136 - External Media Tests: Fix typos, update context usage, update gmp reset script. r?maja_zf

https://reviewboard.mozilla.org/r/56796/#review53590
Attachment #8758521 - Flags: review?(mjzffr) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23fde8ecfa91
External Media Tests: Fix typos, update context usage, update gmp reset script. r=maja_zf
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/23fde8ecfa91
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.