Closed Bug 1277167 Opened 5 years ago Closed 2 months ago

Crash in mozilla::widget::WindowHook::Lookup at CreateTaskbarTabPreview

Categories

(Core :: Widget: Win32, defect, P3)

All
Windows
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox49 --- wontfix
firefox-esr45 --- wontfix
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- wontfix
firefox-esr52 --- wontfix
firefox59 --- affected
firefox60 --- affected
firefox61 --- affected
firefox62 --- affected
firefox63 --- affected
firefox64 --- affected

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

(Keywords: crash, Whiteboard: tpi:+, widget-next)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-27e3ec1f-4bdf-4b72-b894-1584a2160525.
=============================================================

This crash is that window handle is invalid or destroyed when CreateTaskbarTabPreview() is called.  By bug 557931, some was fixed.  But this crash still occurs.
CreateTaskbarTabPreview doesn't check whether window is alive.  So we should check it to avoid crash.

Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59384/
Attachment #8763024 - Flags: review?(jmathies)
(In reply to Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) from comment #1)
> Created attachment 8763024 [details]
> Bug 1277167 - CreateTaskbarTabPreview should return error when we cannot get
> nsWindow object from toplevel HWND.
> 
> CreateTaskbarTabPreview doesn't check whether window is alive.  So we should
> check it to avoid crash.
> 
> Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/59384/

This patch doesn't look right, did you upload the wrong thing?
Flags: needinfo?(m_kato)
Attachment #8763024 - Flags: review?(jmathies)
Crash volume for signature 'mozilla::widget::WindowHook::Lookup':
 - nightly (version 52): 6 crashes from 2016-09-19.
 - aurora  (version 51): 8 crashes from 2016-09-19.
 - beta    (version 50): 83 crashes from 2016-09-20.
 - release (version 49): 643 crashes from 2016-09-05.
 - esr     (version 45): 905 crashes from 2016-06-01.

Crash volume on the last weeks (Week N is from 10-03 to 10-09):
            W. N-1  W. N-2
 - nightly       4       2
 - aurora        6       2
 - beta         77       6
 - release     510     133
 - esr          74      68

Affected platform: Windows

Crash rank on the last 7 days:
           Browser     Content   Plugin
 - nightly #231
 - aurora  #196
 - beta    #190
 - release #89
 - esr     #149
Rethinking new fix...
Flags: needinfo?(m_kato)
Priority: -- → P2
Whiteboard: tpi:+
Mass wontfix for bugs affecting firefox 52.
This showed up in the 59.0.2 "spike" report, although the spike looks relatively small. Comments mention Firefox being not responsive and one mention of an unresponsive script.
See Also: → 1485253
Crash Signature: [@ mozilla::widget::WindowHook::Lookup] → [@ mozilla::widget::WindowHook::Lookup] [@ mozilla::widget::WindowHook::LookupOrCreate ]
OS: Windows 8 → Windows
Hardware: x86 → All
Priority: P2 → P3
Whiteboard: tpi:+ → tpi:+, widget-next

(In reply to Makoto Kato [:m_kato] from comment #5)

Rethinking new fix...

?

Blocks: 1516423
Flags: needinfo?(m_kato)

Thanks for the heads up!

Status: NEW → RESOLVED
Closed: 2 months ago
Flags: needinfo?(jmathies)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.