Closed Bug 1277167 Opened 5 years ago Closed 2 months ago
Crash in mozilla::widget::Window
Hook::Lookup at Create Taskbar Tab Preview
Bug 1277167 - CreateTaskbarTabPreview should return error when we cannot get nsWindow object from toplevel HWND.
58 bytes, text/x-review-board-request
This bug was filed from the Socorro interface and is report bp-27e3ec1f-4bdf-4b72-b894-1584a2160525. ============================================================= This crash is that window handle is invalid or destroyed when CreateTaskbarTabPreview() is called. By bug 557931, some was fixed. But this crash still occurs.
CreateTaskbarTabPreview doesn't check whether window is alive. So we should check it to avoid crash. Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59384/
(In reply to Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) from comment #1) > Created attachment 8763024 [details] > Bug 1277167 - CreateTaskbarTabPreview should return error when we cannot get > nsWindow object from toplevel HWND. > > CreateTaskbarTabPreview doesn't check whether window is alive. So we should > check it to avoid crash. > > Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header > See other reviews: https://reviewboard.mozilla.org/r/59384/ This patch doesn't look right, did you upload the wrong thing?
5 years ago
Duplicate of this bug: 556524
Crash volume for signature 'mozilla::widget::WindowHook::Lookup': - nightly (version 52): 6 crashes from 2016-09-19. - aurora (version 51): 8 crashes from 2016-09-19. - beta (version 50): 83 crashes from 2016-09-20. - release (version 49): 643 crashes from 2016-09-05. - esr (version 45): 905 crashes from 2016-06-01. Crash volume on the last weeks (Week N is from 10-03 to 10-09): W. N-1 W. N-2 - nightly 4 2 - aurora 6 2 - beta 77 6 - release 510 133 - esr 74 68 Affected platform: Windows Crash rank on the last 7 days: Browser Content Plugin - nightly #231 - aurora #196 - beta #190 - release #89 - esr #149
Rethinking new fix...
This showed up in the 59.0.2 "spike" report, although the spike looks relatively small. Comments mention Firefox being not responsive and one mention of an unresponsive script.
Flags: needinfo?(m_kato) → needinfo?(jmathies)
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.