1277167 - Crash in mozilla::widget::WindowHook::Lookup at CreateTaskbarTabPreview

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect, P3)

Description

[Makoto Kato [:m_kato]]

This bug was filed from the Socorro interface and is 
report bp-27e3ec1f-4bdf-4b72-b894-1584a2160525.
=============================================================

This crash is that window handle is invalid or destroyed when CreateTaskbarTabPreview() is called.  By bug 557931, some was fixed.  But this crash still occurs.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1277167 - CreateTaskbarTabPreview should return error when we cannot get nsWindow object from toplevel HWND.

CreateTaskbarTabPreview doesn't check whether window is alive.  So we should check it to avoid crash.

Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59384/

Comment 2

[Jim Mathies [:jimm]]

(In reply to Makoto Kato [:m_kato] (PTO 6/20-21, 6/24) from comment #1)
> Created attachment 8763024 [details]
> Bug 1277167 - CreateTaskbarTabPreview should return error when we cannot get
> nsWindow object from toplevel HWND.
> 
> CreateTaskbarTabPreview doesn't check whether window is alive.  So we should
> check it to avoid crash.
> 
> Review commit: https://reviewboard.mozilla.org/r/59384/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/59384/

This patch doesn't look right, did you upload the wrong thing?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'mozilla::widget::WindowHook::Lookup':
 - nightly (version 52): 6 crashes from 2016-09-19.
 - aurora  (version 51): 8 crashes from 2016-09-19.
 - beta    (version 50): 83 crashes from 2016-09-20.
 - release (version 49): 643 crashes from 2016-09-05.
 - esr     (version 45): 905 crashes from 2016-06-01.

Crash volume on the last weeks (Week N is from 10-03 to 10-09):
            W. N-1  W. N-2
 - nightly       4       2
 - aurora        6       2
 - beta         77       6
 - release     510     133
 - esr          74      68

Affected platform: Windows

Crash rank on the last 7 days:
           Browser     Content   Plugin
 - nightly #231
 - aurora  #196
 - beta    #190
 - release #89
 - esr     #149

Comment 5

[Makoto Kato [:m_kato]]

Rethinking new fix...

Comment 6

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 7

[Marcia Knous [:marcia]]

This showed up in the 59.0.2 "spike" report, although the spike looks relatively small. Comments mention Firefox being not responsive and one mention of an unresponsive script.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Makoto Kato [:m_kato] from comment #5)

Rethinking new fix...

?

Comment 9

[Wayne Mery (:wsmwk)]

No firefox crashes after 76.x
https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3Awidget%3A%3AWindowHook%3A%3ALookupOrCreate&date=%3E%3D2020-09-17T06%3A05%3A00.000Z&date=%3C2020-10-17T06%3A05%3A00.000Z#summary

Comment 10

[Jim Mathies [:jimm]]

Thanks for the heads up!