Consolidate the logic of AudioStream::Pause()/Resume()

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
It is possible for mState to become DRAINED before cubeb_stream_stop/start returns. We should not transition to other states if mState is DRAINED.

Hope this will fix the crash in bug 1246108 comment 29.
(Assignee)

Updated

3 years ago
Assignee: nobody → jwwang
Blocks: 1274160
(Assignee)

Comment 1

3 years ago
Created attachment 8759045 [details]
MozReview Request: Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/57130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57130/
Attachment #8759045 - Flags: review?(kinetik)
Comment on attachment 8759045 [details]
MozReview Request: Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.

https://reviewboard.mozilla.org/r/57130/#review53890
Attachment #8759045 - Flags: review?(kinetik) → review+
(Assignee)

Comment 3

3 years ago
Thanks!

Comment 4

3 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/479829a9d620
don't transition to other states when the stream is already drained. r=kinetik.

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/479829a9d620
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.