Closed Bug 1277171 Opened 6 years ago Closed 6 years ago

Consolidate the logic of AudioStream::Pause()/Resume()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It is possible for mState to become DRAINED before cubeb_stream_stop/start returns. We should not transition to other states if mState is DRAINED.

Hope this will fix the crash in bug 1246108 comment 29.
Assignee: nobody → jwwang
Blocks: 1274160
Comment on attachment 8759045 [details]
MozReview Request: Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.

https://reviewboard.mozilla.org/r/57130/#review53890
Attachment #8759045 - Flags: review?(kinetik) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/479829a9d620
don't transition to other states when the stream is already drained. r=kinetik.
https://hg.mozilla.org/mozilla-central/rev/479829a9d620
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.