1277171 - Consolidate the logic of AudioStream::Pause()/Resume()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

It is possible for mState to become DRAINED before cubeb_stream_stop/start returns. We should not transition to other states if mState is DRAINED.

Hope this will fix the crash in bug 1246108 comment 29.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/57130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57130/

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8759045 [details]
MozReview Request: Bug 1277171 - don't transition to other states when the stream is already drained. r=kinetik.

https://reviewboard.mozilla.org/r/57130/#review53890

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/479829a9d620
don't transition to other states when the stream is already drained. r=kinetik.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/479829a9d620