1277175 - Remove AudioStream::IsPaused()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

mState can be changed by StateCallback() on another thread. It is usually racy to query the pause state and then decide what to do because mState could change in between the calls.

AudioStream should figure out what to do based on its state. This is especially true for Pause() and Resume().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1277175 - Remove AudioStream::IsPaused(). r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/57140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57140/

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8759054 [details]
MozReview Request: Bug 1277175 - Remove AudioStream::IsPaused(). r=kinetik.

https://reviewboard.mozilla.org/r/57140/#review53888

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71581f487d7c
Remove AudioStream::IsPaused(). r=kinetik.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71581f487d7c