Closed Bug 1277188 Opened 4 years ago Closed 4 years ago

Remove dependency on AudioStream from AudioClock

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

We want to get rid of bi-directional dependency to make code simpler.
Assignee: nobody → jwwang
Blocks: 1274160
Review commit: https://reviewboard.mozilla.org/r/57476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57476/
Attachment #8759481 - Flags: review?(kinetik)
Attachment #8759482 - Flags: review?(kinetik)
Attachment #8759483 - Flags: review?(kinetik)
Attachment #8759484 - Flags: review?(kinetik)
Attachment #8759485 - Flags: review?(kinetik)
Comment on attachment 8759481 [details]
Bug 1277188. Part 1 - fix AudioStream::GetPosition(). .

https://reviewboard.mozilla.org/r/57476/#review54238
Attachment #8759481 - Flags: review?(kinetik) → review+
Comment on attachment 8759482 [details]
Bug 1277188. Part 2 - fix AudioStream::GetPositionInFrames(). .

https://reviewboard.mozilla.org/r/57478/#review54242
Attachment #8759482 - Flags: review?(kinetik) → review+
Comment on attachment 8759483 [details]
Bug 1277188. Part 3 - remove AudioClock::GetPositionUnlocked(). .

https://reviewboard.mozilla.org/r/57480/#review54244
Attachment #8759483 - Flags: review?(kinetik) → review+
Attachment #8759484 - Flags: review?(kinetik) → review+
Attachment #8759485 - Flags: review?(kinetik) → review+
Comment on attachment 8759485 [details]
Bug 1277188. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). .

https://reviewboard.mozilla.org/r/57484/#review54248
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2692780925cf
Part 1 - fix AudioStream::GetPosition(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f157a49a16
Part 2 - fix AudioStream::GetPositionInFrames(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/76384d9681f0
Part 3 - remove AudioClock::GetPositionUnlocked(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f33d9a58e72
Part 4 - remove AudioClock::mAudioStream. r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a340f7b143e3
Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). r=kinetik.
Blocks: 1277776
You need to log in before you can comment on or make changes to this bug.