Closed
Bug 1277188
Opened 8 years ago
Closed 8 years ago
Remove dependency on AudioStream from AudioClock
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
58 bytes,
text/x-review-board-request
|
kinetik
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kinetik
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kinetik
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kinetik
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
kinetik
:
review+
|
Details |
We want to get rid of bi-directional dependency to make code simpler.
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e6986093035
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57476/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57476/
Attachment #8759481 -
Flags: review?(kinetik)
Attachment #8759482 -
Flags: review?(kinetik)
Attachment #8759483 -
Flags: review?(kinetik)
Attachment #8759484 -
Flags: review?(kinetik)
Attachment #8759485 -
Flags: review?(kinetik)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57478/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57478/
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57480/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57480/
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57482/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57482/
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57484/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57484/
Comment 7•8 years ago
|
||
Comment on attachment 8759481 [details] Bug 1277188. Part 1 - fix AudioStream::GetPosition(). . https://reviewboard.mozilla.org/r/57476/#review54238
Attachment #8759481 -
Flags: review?(kinetik) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8759482 [details] Bug 1277188. Part 2 - fix AudioStream::GetPositionInFrames(). . https://reviewboard.mozilla.org/r/57478/#review54242
Attachment #8759482 -
Flags: review?(kinetik) → review+
Comment 9•8 years ago
|
||
Comment on attachment 8759483 [details] Bug 1277188. Part 3 - remove AudioClock::GetPositionUnlocked(). . https://reviewboard.mozilla.org/r/57480/#review54244
Attachment #8759483 -
Flags: review?(kinetik) → review+
Updated•8 years ago
|
Attachment #8759484 -
Flags: review?(kinetik) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8759484 [details] Bug 1277188. Part 4 - remove AudioClock::mAudioStream. . https://reviewboard.mozilla.org/r/57482/#review54246
Updated•8 years ago
|
Attachment #8759485 -
Flags: review?(kinetik) → review+
Comment 11•8 years ago
|
||
Comment on attachment 8759485 [details] Bug 1277188. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). . https://reviewboard.mozilla.org/r/57484/#review54248
Assignee | ||
Comment 12•8 years ago
|
||
Thanks for the review!
Comment 13•8 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2692780925cf Part 1 - fix AudioStream::GetPosition(). r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/79f157a49a16 Part 2 - fix AudioStream::GetPositionInFrames(). r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/76384d9681f0 Part 3 - remove AudioClock::GetPositionUnlocked(). r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/6f33d9a58e72 Part 4 - remove AudioClock::mAudioStream. r=kinetik. https://hg.mozilla.org/integration/mozilla-inbound/rev/a340f7b143e3 Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). r=kinetik.
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2692780925cf https://hg.mozilla.org/mozilla-central/rev/79f157a49a16 https://hg.mozilla.org/mozilla-central/rev/76384d9681f0 https://hg.mozilla.org/mozilla-central/rev/6f33d9a58e72 https://hg.mozilla.org/mozilla-central/rev/a340f7b143e3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•