1277188 - Remove dependency on AudioStream from AudioClock

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We want to get rid of bi-directional dependency to make code simpler.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e6986093035

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277188. Part 1 - fix AudioStream::GetPosition(). .

Review commit: https://reviewboard.mozilla.org/r/57476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57476/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277188. Part 2 - fix AudioStream::GetPositionInFrames(). .

Review commit: https://reviewboard.mozilla.org/r/57478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57478/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277188. Part 3 - remove AudioClock::GetPositionUnlocked(). .

Review commit: https://reviewboard.mozilla.org/r/57480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57480/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277188. Part 4 - remove AudioClock::mAudioStream. .

Review commit: https://reviewboard.mozilla.org/r/57482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57482/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277188. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). .

Review commit: https://reviewboard.mozilla.org/r/57484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57484/

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8759481 [details]
Bug 1277188. Part 1 - fix AudioStream::GetPosition(). .

https://reviewboard.mozilla.org/r/57476/#review54238

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 8759482 [details]
Bug 1277188. Part 2 - fix AudioStream::GetPositionInFrames(). .

https://reviewboard.mozilla.org/r/57478/#review54242

Comment 9

[Matthew Gregan [:kinetik]]

Comment on attachment 8759483 [details]
Bug 1277188. Part 3 - remove AudioClock::GetPositionUnlocked(). .

https://reviewboard.mozilla.org/r/57480/#review54244

Comment 10

[Matthew Gregan [:kinetik]]

Comment on attachment 8759484 [details]
Bug 1277188. Part 4 - remove AudioClock::mAudioStream. .

https://reviewboard.mozilla.org/r/57482/#review54246

Comment 11

[Matthew Gregan [:kinetik]]

Comment on attachment 8759485 [details]
Bug 1277188. Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). .

https://reviewboard.mozilla.org/r/57484/#review54248

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2692780925cf
Part 1 - fix AudioStream::GetPosition(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f157a49a16
Part 2 - fix AudioStream::GetPositionInFrames(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/76384d9681f0
Part 3 - remove AudioClock::GetPositionUnlocked(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f33d9a58e72
Part 4 - remove AudioClock::mAudioStream. r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a340f7b143e3
Part 5 - rename AudioClock::SetPlaybackRateUnlocked(). r=kinetik.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2692780925cf
https://hg.mozilla.org/mozilla-central/rev/79f157a49a16
https://hg.mozilla.org/mozilla-central/rev/76384d9681f0
https://hg.mozilla.org/mozilla-central/rev/6f33d9a58e72
https://hg.mozilla.org/mozilla-central/rev/a340f7b143e3