Closed Bug 1277197 Opened 8 years ago Closed 8 years ago

JavaScript Error: "NS_NOINTERFACE: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]" {file: "jar:file:///system/b2g/omni.ja!/components/PresentationRequestUIGlue.js" line: 26}

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.6+, firefox49 fixed, b2g-v2.6 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.6+
Tracking Flags:
Tracking Status
firefox49 --- fixed
b2g-v2.6 --- fixed

People

(Reporter: schien, Assigned: schien)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 files)

bug1277197-fix-js-error-in-ui-glue.patch
1.13 KB, patch
kuoe0.tw
: review+
jocheng
: approval-mozilla-b2g48+
Details | Diff | Splinter Review
pull request for tv 2.6
48 bytes, text/x-github-pull-request
Details | Review 
QueryInterface to a non-implemented interface will throw an exception in JS.

>E/GeckoConsole(  170): [JavaScript Error: "NS_NOINTERFACE: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]" {file: "jar:file:///system/b2g/omni.ja!/components/PresentationRequestUIGlue.js" line: 26}]
trivial patch. sadly we didn't have test case to catch this earlier.
Attachment #8758635 - Flags: review?(kuoe0)
Comment on attachment 8758635 [details] [diff] [review]
bug1277197-fix-js-error-in-ui-glue.patch

Review of attachment 8758635 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8758635 - Flags: review?(kuoe0) → review+
Comment on attachment 8758635 [details] [diff] [review]
bug1277197-fix-js-error-in-ui-glue.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1235123
User impact if declined: presentation api for TV is broken
Testing completed: manual test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: n/a
Attachment #8758635 - Flags: approval-mozilla-b2g48?
Comment on attachment 8758644 [details] [review]
pull request for tv 2.6

ready to land!
Flags: needinfo?(xeonchen)
Comment on attachment 8758635 [details] [diff] [review]
bug1277197-fix-js-error-in-ui-glue.patch

Approve for TV 2.6
Attachment #8758635 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+
blocking-b2g: 2.6? → 2.6+
status-b2g-v2.6: --- → affected
Pushed by gachen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fced3739df6b
fix JS error in PresentationRequestUIGlue for 2-UAs device. r=kuoe0.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fced3739df6b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: