Remove AudioStream::mInRate/mOutRate

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
We already have AudioClock::mInRate/mOutRate. We don't want duplicated copies to increase maintenance effort.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1274160
(Assignee)

Comment 2

2 years ago
Created attachment 8760119 [details]
Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. .

Review commit: https://reviewboard.mozilla.org/r/57836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57836/
Attachment #8760119 - Flags: review?(kinetik)
Attachment #8760120 - Flags: review?(kinetik)
Attachment #8760121 - Flags: review?(kinetik)
(Assignee)

Comment 4

2 years ago
Created attachment 8760121 [details]
Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. .

Review commit: https://reviewboard.mozilla.org/r/57840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57840/
Comment on attachment 8760119 [details]
Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. .

https://reviewboard.mozilla.org/r/57836/#review54670
Attachment #8760119 - Flags: review?(kinetik) → review+
Comment on attachment 8760120 [details]
Bug 1277198. Part 2 - fix OpenDumpFile(). .

https://reviewboard.mozilla.org/r/57838/#review54672
Attachment #8760120 - Flags: review?(kinetik) → review+
Comment on attachment 8760121 [details]
Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. .

https://reviewboard.mozilla.org/r/57840/#review54674
Attachment #8760121 - Flags: review?(kinetik) → review+
(Assignee)

Comment 8

2 years ago
Thanks for the review!

Comment 9

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/407310ae3088
Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/31d28c8d3284
Part 2 - fix OpenDumpFile(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/58b8b9310520
Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/407310ae3088
https://hg.mozilla.org/mozilla-central/rev/31d28c8d3284
https://hg.mozilla.org/mozilla-central/rev/58b8b9310520
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.