Closed Bug 1277198 Opened 6 years ago Closed 6 years ago

Remove AudioStream::mInRate/mOutRate

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We already have AudioClock::mInRate/mOutRate. We don't want duplicated copies to increase maintenance effort.
Assignee: nobody → jwwang
Blocks: 1274160
Comment on attachment 8760119 [details]
Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. .

https://reviewboard.mozilla.org/r/57836/#review54670
Attachment #8760119 - Flags: review?(kinetik) → review+
Comment on attachment 8760120 [details]
Bug 1277198. Part 2 - fix OpenDumpFile(). .

https://reviewboard.mozilla.org/r/57838/#review54672
Attachment #8760120 - Flags: review?(kinetik) → review+
Comment on attachment 8760121 [details]
Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. .

https://reviewboard.mozilla.org/r/57840/#review54674
Attachment #8760121 - Flags: review?(kinetik) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/407310ae3088
Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/31d28c8d3284
Part 2 - fix OpenDumpFile(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/58b8b9310520
Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.
You need to log in before you can comment on or make changes to this bug.