1277198 - Remove AudioStream::mInRate/mOutRate

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

We already have AudioClock::mInRate/mOutRate. We don't want duplicated copies to increase maintenance effort.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=402b155ec8c0

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. .

Review commit: https://reviewboard.mozilla.org/r/57836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57836/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277198. Part 2 - fix OpenDumpFile(). .

Review commit: https://reviewboard.mozilla.org/r/57838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57838/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. .

Review commit: https://reviewboard.mozilla.org/r/57840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57840/

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8760119 [details]
Bug 1277198. Part 1 - add AudioClock::GetInputRate/GetOutputRate. .

https://reviewboard.mozilla.org/r/57836/#review54670

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8760120 [details]
Bug 1277198. Part 2 - fix OpenDumpFile(). .

https://reviewboard.mozilla.org/r/57838/#review54672

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8760121 [details]
Bug 1277198. Part 3 - remove AudioStream::mInRate/mOutRate. .

https://reviewboard.mozilla.org/r/57840/#review54674

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/407310ae3088
Part 1 - add AudioClock::GetInputRate/GetOutputRate. r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/31d28c8d3284
Part 2 - fix OpenDumpFile(). r=kinetik.
https://hg.mozilla.org/integration/mozilla-inbound/rev/58b8b9310520
Part 3 - remove AudioStream::mInRate/mOutRate. r=kinetik.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/407310ae3088
https://hg.mozilla.org/mozilla-central/rev/31d28c8d3284
https://hg.mozilla.org/mozilla-central/rev/58b8b9310520