Closed
Bug 1277351
Opened 10 years ago
Closed 10 years ago
[CID 1362438] Null pointer dereferences in ssl3_SetCipherSuite()
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.25
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
1.41 KB,
patch
|
ekr
:
review+
|
Details | Diff | Splinter Review |
*** CID 1362438: Null pointer dereferences (REVERSE_INULL)
/lib/ssl/ssl3con.c: 6865 in ssl3_SetCipherSuite()
6859 {
6860 ss->ssl3.hs.cipher_suite = chosenSuite;
6861 ss->ssl3.hs.suite_def = ssl_LookupCipherSuiteDef(chosenSuite);
6862 ss->ssl3.hs.kea_def = &kea_defs[ss->ssl3.hs.suite_def->key_exchange_alg];
6863 ss->ssl3.hs.preliminaryInfo |= ssl_preinfo_cipher_suite;
6864
>>> CID 1362438: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "ss->ssl3.hs.suite_def" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
6865 if (!ss->ssl3.hs.suite_def) {
6866 PORT_Assert(0);
6867 PORT_SetError(SEC_ERROR_LIBRARY_FAILURE);
6868 return SECFailure;
6869 }
6870
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8758863 -
Flags: review?(martin.thomson)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8758863 [details] [diff] [review]
0001-Bug-1277351-Fix-possible-null-pointer-dereference-in.patch
Review of attachment 8758863 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8758863 -
Flags: review?(martin.thomson) → review+
|
||
Updated•10 years ago
|
Blocks: nss-coverity
Keywords: coverity
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.25
You need to log in
before you can comment on or make changes to this bug.
Description
•