[webvtt] Process cue and apply related CSS attributes on the div element
Categories
(Core :: Audio/Video: Playback, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
https://w3c.github.io/webvtt/#apply-webvtt-cue-settings Follow the step1~step8 in the spec.
Updated•7 years ago
|
Mass change P2 -> P3
Updated•7 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
There is no need to check whether the code is running on other browser, because we won't upstream the change back to the github repo, as this code uses a lots mozilla-only APIs.
Assignee | ||
Comment 3•4 years ago
|
||
Using class syntax for CueStyleBox made us easier to simplify the code and make it more readable.
Assignee | ||
Comment 4•4 years ago
|
||
Follow the spec 7.2 and 7.4 to process cue and apply css setting for the div element.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
CueStyleBox should handle all css attributes, so it make more sense to adjust font size and style inside CueStyleBox.
Assignee | ||
Comment 6•4 years ago
|
||
If cue div is not a pseudo element, which means we don't have a default style applying on it. Therefore, we should set the default css style for it.
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/797abfd47a05 part1 : remove UA agent checkings. r=heycam https://hg.mozilla.org/integration/autoland/rev/45a5af08e7f6 part2 : make CueStyleBox class-based. r=heycam https://hg.mozilla.org/integration/autoland/rev/f21dc82d9ba7 part3 : apply WebVTT cue settings. r=heycam https://hg.mozilla.org/integration/autoland/rev/b6a5f3dc8878 part4 : change font size internally in CueStyleBox. r=heycam https://hg.mozilla.org/integration/autoland/rev/eff6eff2d385 part5 : apply default style on cue when we don't use pseudo element. r=heycam
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/797abfd47a05
https://hg.mozilla.org/mozilla-central/rev/45a5af08e7f6
https://hg.mozilla.org/mozilla-central/rev/f21dc82d9ba7
https://hg.mozilla.org/mozilla-central/rev/b6a5f3dc8878
https://hg.mozilla.org/mozilla-central/rev/eff6eff2d385
Comment 9•4 years ago
|
||
bugherder |
Description
•