Closed
Bug 1277473
Opened 9 years ago
Closed 9 years ago
Data race in accessing gDumpedAudioCount from OpenDumpFile()
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
https://hg.mozilla.org/mozilla-central/file/4d63dde701b47b8661ab7990f197b6b60e543839/dom/media/AudioStream.cpp#l250
It is a data race to share gDumpedAudioCount among threads without synchronization. Chances are there are file name collisions when opening dump files by different AudioStream instances.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57858/
Attachment #8760140 -
Flags: review?(kinetik)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8760140 [details]
Bug 1277473 - fix data race in gDumpedAudioCount. .
https://reviewboard.mozilla.org/r/57858/#review54918
Attachment #8760140 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b093026fc747
fix data race in gDumpedAudioCount. r=kinetik.
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•