Closed Bug 1277555 Opened 7 years ago Closed 7 years ago

Various performance-timeline web-platform-tests are going to permafail when Gecko 49 merges to Aurora

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(firefox47 unaffected, firefox48 unaffected, firefox49+ fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 + fixed

People

(Reporter: RyanVM, Assigned: valentin)

References

Details

Attachments

(1 file, 1 obsolete file)

Set dom.enable_performance_observer pref in performance-timeline web-platform tests
671 bytes, patch
jgraham
: review+
Details | Diff | Splinter Review 
Do we need to make sure a pref is forced on for these?

https://treeherder.mozilla.org/logviewer.html#?job_id=21783499&repo=try#L1395

TEST-UNEXPECTED-FAIL | /performance-timeline/idlharness.html | PerformanceObserverEntryList interface: existence and properties of interface object - assert_own_property: self does not have own property "PerformanceObserverEntryList" expected property "PerformanceObserverEntryList" missing

etc...
Flags: needinfo?(james)
Flags: needinfo?(james) → needinfo?(valentin.gosu)
dom.enable_performance or dom.enable_resource_timing, perhaps, but I'm surprised they're not already on.
The pref seems to be dom.enable_performance_observer - and isn't currently on.
Flags: needinfo?(valentin.gosu) → needinfo?(hiikezoe)
Tracking 49+ to keep this on the radar - valentin can you own this bug or should someone else?
tracking-firefox49: ? → +
Flags: needinfo?(valentin.gosu)
(In reply to James Graham [:jgraham] from comment #1)
> dom.enable_performance or dom.enable_resource_timing, perhaps, but I'm
> surprised they're not already on.

The preference value is enabled only on nightly.  
Is there any way to check preference value in meta files (idlharness.html.ini, etc.)?
Flags: needinfo?(hiikezoe)
It's either this, or disabling the tests on only on aurora
Attachment #8759405 - Flags: review?(james)
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Thank you, Valentin!
For a cleaner solution, you could use __dir__.ini to set the pref for all tests inside that directory as well. For example:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/harness/test/metadata/testharness/firefox/__dir__.ini
I will use them from next time.  Thank you, both!
This is much better. Thanks for the suggestion, Ryan!
Attachment #8759417 - Flags: review?(james)
Attachment #8759405 - Attachment is obsolete: true
Attachment #8759405 - Flags: review?(james)
Flags: needinfo?(valentin.gosu)
Attachment #8759417 - Flags: review?(james) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/139ce9bc8149
Set dom.enable_performance_observer pref in performance-timeline web-platform tests r=jgraham
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/139ce9bc8149
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.