Closed
Bug 1277555
Opened 9 years ago
Closed 9 years ago
Various performance-timeline web-platform-tests are going to permafail when Gecko 49 merges to Aurora
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox47 unaffected, firefox48 unaffected, firefox49+ fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | unaffected |
firefox49 | + | fixed |
People
(Reporter: RyanVM, Assigned: valentin)
References
Details
Attachments
(1 file, 1 obsolete file)
671 bytes,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
Do we need to make sure a pref is forced on for these?
https://treeherder.mozilla.org/logviewer.html#?job_id=21783499&repo=try#L1395
TEST-UNEXPECTED-FAIL | /performance-timeline/idlharness.html | PerformanceObserverEntryList interface: existence and properties of interface object - assert_own_property: self does not have own property "PerformanceObserverEntryList" expected property "PerformanceObserverEntryList" missing
etc...
Flags: needinfo?(james)
Updated•9 years ago
|
Flags: needinfo?(james) → needinfo?(valentin.gosu)
Comment 1•9 years ago
|
||
dom.enable_performance or dom.enable_resource_timing, perhaps, but I'm surprised they're not already on.
Assignee | ||
Comment 2•9 years ago
|
||
The pref seems to be dom.enable_performance_observer - and isn't currently on.
Flags: needinfo?(valentin.gosu) → needinfo?(hiikezoe)
Comment 3•9 years ago
|
||
Tracking 49+ to keep this on the radar - valentin can you own this bug or should someone else?
Flags: needinfo?(valentin.gosu)
Comment 4•9 years ago
|
||
(In reply to James Graham [:jgraham] from comment #1)
> dom.enable_performance or dom.enable_resource_timing, perhaps, but I'm
> surprised they're not already on.
The preference value is enabled only on nightly.
Is there any way to check preference value in meta files (idlharness.html.ini, etc.)?
Flags: needinfo?(hiikezoe)
Assignee | ||
Comment 5•9 years ago
|
||
It's either this, or disabling the tests on only on aurora
Attachment #8759405 -
Flags: review?(james)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Comment 6•9 years ago
|
||
Thank you, Valentin!
Reporter | ||
Comment 7•9 years ago
|
||
For a cleaner solution, you could use __dir__.ini to set the pref for all tests inside that directory as well. For example:
https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/harness/test/metadata/testharness/firefox/__dir__.ini
Comment 8•9 years ago
|
||
I will use them from next time. Thank you, both!
Assignee | ||
Comment 9•9 years ago
|
||
This is much better. Thanks for the suggestion, Ryan!
Attachment #8759417 -
Flags: review?(james)
Assignee | ||
Updated•9 years ago
|
Attachment #8759405 -
Attachment is obsolete: true
Attachment #8759405 -
Flags: review?(james)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(valentin.gosu)
Updated•9 years ago
|
Attachment #8759417 -
Flags: review?(james) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/139ce9bc8149
Set dom.enable_performance_observer pref in performance-timeline web-platform tests r=jgraham
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 12•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•