Closed Bug 1277556 Opened 10 years ago Closed 10 years ago

iframe-allowfullscreen.html is going to permafail when Gecko 49 merges to Beta

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- fixed

People

(Reporter: RyanVM, Unassigned)

References

(Depends on 1 open bug)

Details

https://treeherder.mozilla.org/logviewer.html#?job_id=21785528&repo=try#L7267 TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html | iframe-allowfullscreen - assert_true: Top level document has fullscreen enabled flag set expected true got undefined TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html | iframe-sandbox-allowfullscreen - assert_true: Top level document has fullscreen enabled flag set expected true got undefined TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html | iframe-allowfullscreen-dialog - assert_true: Top level document has fullscreen enabled flag set expected true got undefined TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html | iframe-sandbox-allowfullscreen-dialog - assert_true: Top level document has fullscreen enabled flag set expected true got undefined
Flags: needinfo?(bugzilla)
The patch in bug 1274534 incorrectly removed the iframe-allowfullscreen.html.ini file which includes the necessary pref for this test to run properly on beta and release. Restoring that file is easy, but I think it would be good to ask James not to remove this kind of meta file :)
Blocks: 1274534
Flags: needinfo?(bugzilla) → needinfo?(james)
That is a known bug in the tooling that I need to investigate.
Depends on: 1264269
Flags: needinfo?(james)
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/981ea1b8f2e7 Bring back a needed .ini file rs=ryanvm
Brought that ini file back manually for now. It'll probably get deleted the next time wpt gets an update unless bug 1264269 gets fixed, but this should hopefully get us through the uplift date.
https://hg.mozilla.org/mozilla-central/rev/981ea1b8f2e7
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
So on the latest uplift simulations, it looks like this test is going to start permafailing again when Firefox 50 merges from m-c to beta AND when Firefox 49 merges from aurora to beta: https://treeherder.mozilla.org/#/jobs?repo=try&author=ryanvm@gmail.com&fromchange=300aefc49d14ef117af8fb736ee1d56890b3987f&group_state=expanded&tochange=997b501464a900f3be51f5aa59c1630aa2ca2f5a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&filter-searchStr=web-&selectedJob=22462169 That ini file *is* still present on the tip of Firefox 50, but it isn't present anymore on Firefox 49.
Flags: needinfo?(bugzilla)
It seems to me the ini file is still present in pushes you listed in the link, e.g. https://hg.mozilla.org/try/file/997b501464a9/testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element https://hg.mozilla.org/try/file/75b073f4aa16/testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element Since the failure only happens in Tier 2 tc, could it be some issue of tc? There could be some version control tool issue I suppose.
Flags: needinfo?(bugzilla)
It's happening across all platforms, not just Tier 2.
Oh, I see... I have no idea, then. It seems to me the ini file still exists...
Wait... the file content is not correct... The first line should be > [iframe-allowfullscreen.html.ini] not > [iframe-allow-fullscreen.html.ini] Not sure what happened.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.