Closed Bug 1277569 Opened 7 years ago Closed 7 years ago

For compatibility reasons, application attempts to disable the SSL v2 protocol should continue to work.

Categories

(NSS :: Libraries, defect)

Product:
NSS
Component:
Libraries
Version:
3.25
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Patch v2
3.38 KB, patch
ekr
: review+
Details | Diff | Splinter Review
Patch v3
712 bytes, patch
franziskus
: review+
Details | Diff | Splinter Review 
After the removal of SSL v2 code from NSS, if an application attempts to disable the SSL v2 protocol, a failure is returned.

This may cause older applications, linked against newer NSS, to fail.

This is an unnecessary failure. If the application wants it disabled, and we have already disabled it, then we should return a success.

Only attempts to enable SSL v2 should result in a failure.
Attached patch 1277569-v1.patch (obsolete) — — Splinter Review 
Assignee: nobody → kaie

        Attachment #8759224 -
        Flags: review?(franziskuskiefer)

    
    

    
  
Comment on attachment 8759224 [details] [diff] [review]
1277569-v1.patch

<ekr> kaie: don't you need SSL_OptionGet() and SSL_Option{Set,Get}Default()?

Right.

        Attachment #8759224 -
        Attachment is obsolete: true

        Attachment #8759224 -
        Flags: review?(franziskuskiefer)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v2
        — 
          — Splinter Review
      

    


  

        Attachment #8759229 -
        Flags: review?(ekr)

    
    

    
  
Comment on attachment 8759229 [details] [diff] [review]
Patch v2

Review of attachment 8759229 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

        Attachment #8759229 -
        Flags: review?(ekr) → review+

    
    

    
  
https://hg.mozilla.org/projects/nss/rev/e7bc5b1992d4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.25

    
  
Keywords: regression

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v3
        — 
          — Splinter Review
      

    


  
Sorry, the SetDefault function doesn't use an "rv" variable, it returns immediately on failure.

Incremental fix attached.

        Attachment #8759238 -
        Flags: review?(franziskuskiefer)

        Attachment #8759238 -
        Flags: review?(franziskuskiefer) → review+

          You need to log in
          before you can comment on or make changes to this bug.