Closed Bug 1277571 Opened 7 years ago Closed 7 years ago

Fix "TypeError: this is null: HTMLBreadcrumbs.prototype.scroll" in the new HTML breadcrumbs landed with bug 1259812

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Version:
49 Branch
Type:
defect

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Iteration:
49.3 - Jun 6
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

MozReview Request: Bug 1277571 - Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes
58 bytes, text/x-review-board-request
jdescottes
: review+
Details 
See this log: https://treeherder.mozilla.org/logviewer.html#?job_id=9705479&repo=fx-team#L227-L17076
Looks like a simple mistake of forgetting to bind 'scroll' to this.
Blocks: devtools-html-2
Whiteboard: [devtools-html] [triage]
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Comment on attachment 8759177 [details]
MozReview Request: Bug 1277571 - Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes

https://reviewboard.mozilla.org/r/57216/#review53984

Looks good to me!
Attachment #8759177 - Flags: review?(jdescottes) → review+
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a47a4d3877eb
Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/a47a4d3877eb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Iteration: --- → 49.3 - Jun 6
Priority: P2 → P1
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.