Fix "TypeError: this is null: HTMLBreadcrumbs.prototype.scroll" in the new HTML breadcrumbs landed with bug 1259812

RESOLVED FIXED in Firefox 49

Status

P1
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

49 Branch
Firefox 49
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
See this log: https://treeherder.mozilla.org/logviewer.html#?job_id=9705479&repo=fx-team#L227-L17076
Looks like a simple mistake of forgetting to bind 'scroll' to this.

Updated

2 years ago
Blocks: 1263741
Whiteboard: [devtools-html] [triage]
(Assignee)

Comment 1

2 years ago
Created attachment 8759177 [details]
MozReview Request: Bug 1277571 - Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes

Review commit: https://reviewboard.mozilla.org/r/57216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57216/
Attachment #8759177 - Flags: review?(jdescottes)
(Assignee)

Updated

2 years ago
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Comment on attachment 8759177 [details]
MozReview Request: Bug 1277571 - Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes

https://reviewboard.mozilla.org/r/57216/#review53984

Looks good to me!
Attachment #8759177 - Flags: review?(jdescottes) → review+

Comment 3

2 years ago
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/a47a4d3877eb
Bind the scroll function to this in breadcrumbs to pass it to event handlers; r=jdescottes

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a47a4d3877eb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

2 years ago
Iteration: --- → 49.3 - Jun 6
Priority: P2 → P1

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.