1277622 - Use ActorClassWithSpec for the HeapSnapshotFileActor

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We don't have a HeapSnapshotFileFront, this actor is used under the covers in
the MemoryFront, but we should work towards all actors being defined in the
WithSpec way.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use ActorClassWithSpec for the HeapSnapshotFileActor

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b26c7300c60

Comment 3

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8759255 [details] [diff] [review]
Use ActorClassWithSpec for the HeapSnapshotFileActor

Review of attachment 8759255 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/heap-snapshot-file.js
@@ -64,5 @@
>        yield bulk.copyFrom(stream);
>      } finally {
>        stream.close();
>      }
> -  }), {

There's no longer any need to wrap this method in a call to protocol.method() if it doesn't contain a request specification.

::: devtools/shared/specs/heap-snapshot-file.js
@@ +16,5 @@
> +    }
> +  },
> +});
> +
> +exports.heapSnapshotFileSpec = heapSnapshotFileSpec;

Thanks for not using default exports here. Personally, I find this much easier to read :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/2e7770dcd50e
Use ActorClassWithSpec for the HeapSnapshotFileActor; r=ejpbruel

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e7770dcd50e