Closed Bug 1277622 Opened 4 years ago Closed 4 years ago

Use ActorClassWithSpec for the HeapSnapshotFileActor

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.3 - Jun 6
Tracking Status
firefox49 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

We don't have a HeapSnapshotFileFront, this actor is used under the covers in
the MemoryFront, but we should work towards all actors being defined in the
WithSpec way.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b26c7300c60
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Whiteboard: [devtools-html]
Comment on attachment 8759255 [details] [diff] [review]
Use ActorClassWithSpec for the HeapSnapshotFileActor

Review of attachment 8759255 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/heap-snapshot-file.js
@@ -64,5 @@
>        yield bulk.copyFrom(stream);
>      } finally {
>        stream.close();
>      }
> -  }), {

There's no longer any need to wrap this method in a call to protocol.method() if it doesn't contain a request specification.

::: devtools/shared/specs/heap-snapshot-file.js
@@ +16,5 @@
> +    }
> +  },
> +});
> +
> +exports.heapSnapshotFileSpec = heapSnapshotFileSpec;

Thanks for not using default exports here. Personally, I find this much easier to read :-)
Attachment #8759255 - Flags: review?(ejpbruel) → review+
Blocks: 1263289
Whiteboard: [devtools-html] → [devtools-html] [triage]
Iteration: --- → 49.3 - Jun 6
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/2e7770dcd50e
Use ActorClassWithSpec for the HeapSnapshotFileActor; r=ejpbruel
https://hg.mozilla.org/mozilla-central/rev/2e7770dcd50e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Whiteboard: [devtools-html]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.