1277634 - Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=41572e412fe0

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Fix typo.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=842b1323283a

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Fix eslint errors due to moved code not previously eslinting.

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eacaa169e92a

Comment 6

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8759332 [details] [diff] [review]
Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Review of attachment 8759332 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/call-watcher.js
@@ -156,5 @@
>        name: name,
>        stack: stack,
>        timestamp: timestamp
>      };
> -  }, {

You no longer need the call to method() here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9ff998641a49
Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively; r=ejpbruel

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ff998641a49