Closed Bug 1277634 Opened 3 years ago Closed 3 years ago

Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.3 - Jun 6
Tracking Status
firefox49 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=41572e412fe0
Assignee: nobody → nfitzgerald
Blocks: 1263289, 1265719
Status: NEW → ASSIGNED
Whiteboard: [devtools-html]
Flags: qe-verify-
Whiteboard: [devtools-html] → [devtools-html] [triage]
Attachment #8759272 - Attachment is obsolete: true
Attachment #8759272 - Flags: review?(ejpbruel)
Attachment #8759307 - Attachment is obsolete: true
Attachment #8759307 - Flags: review?(ejpbruel)
Blocks: 1277706
No longer blocks: 1263289
Blocks: 1263289
Comment on attachment 8759332 [details] [diff] [review]
Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively

Review of attachment 8759332 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/call-watcher.js
@@ -156,5 @@
>        name: name,
>        stack: stack,
>        timestamp: timestamp
>      };
> -  }, {

You no longer need the call to method() here.
Attachment #8759332 - Flags: review?(ejpbruel) → review+
Iteration: --- → 49.3 - Jun 6
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/9ff998641a49
Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively; r=ejpbruel
https://hg.mozilla.org/mozilla-central/rev/9ff998641a49
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Whiteboard: [devtools-html]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.