Closed Bug 1277656 Opened 7 years ago Closed 7 years ago

create-test-environment should 'exit 1' if building the docker containers fails

Categories

(MozReview Graveyard :: Testing / Development Environment, defect)

Product:
MozReview Graveyard
Component:
Testing / Development Environment
Version:
Development/Staging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: rwood)

Details

Attachments

(1 file, 1 obsolete file)

Testing: Exit with error if building docker images fails (bug 1277656;
58 bytes, text/x-review-board-request
gps
: review+
Details 
During create-test-environment, if building the docker containers fails it should exit the script with exit 1 indicating the script failed. Currently it reports that the docker containers won't work, but doesn't return an error code.

With an exit 1 added, the ./create-test-environment step in jenkins for the mozreviewci would fail out, instead of the CI continuing on and attempting to run the tests anyway.

https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/create-test-environment#l167
Assignee: nobody → rwood
Status: NEW → ASSIGNED
Comment on attachment 8759321 [details]
testing: exit with error if building docker containers fails (bug 1277656);

https://reviewboard.mozilla.org/r/57306/#review54416
Attachment #8759321 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2756877967c1
testing: exit with error if building docker containers fails ; r=gps
Backout by gszorc@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea11a32f0f61
Backed out changeset 2756877967c1 because autoland went crazy
wtf autoland.
Comment on attachment 8759321 [details]
testing: exit with error if building docker containers fails (bug 1277656);

Pushed to the gecko reviewboard by mistake so couldn't autoland, this is now obsolete
Attachment #8759321 - Attachment is obsolete: true
Attachment #8764698 - Flags: review?(gps) → review+
Comment on attachment 8764698 [details]
Testing: Exit with error if building docker images fails (bug 1277656;

https://reviewboard.mozilla.org/r/60408/#review57458
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6b188be657a0
Testing: Exit with error if building docker images fails (bug 1277656; r=gps
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.