1277656 - create-test-environment should 'exit 1' if building the docker containers fails

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[Robert Wood [:rwood]]

During create-test-environment, if building the docker containers fails it should exit the script with exit 1 indicating the script failed. Currently it reports that the docker containers won't work, but doesn't return an error code.

With an exit 1 added, the ./create-test-environment step in jenkins for the mozreviewci would fail out, instead of the CI continuing on and attempting to run the tests anyway.

https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/create-test-environment#l167

Comment 1

[Robert Wood [:rwood]]

Attachment: testing: exit with error if building docker containers fails (bug 1277656);

Review commit: https://reviewboard.mozilla.org/r/57306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57306/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8759321 [details]
testing: exit with error if building docker containers fails (bug 1277656);

https://reviewboard.mozilla.org/r/57306/#review54416

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2756877967c1
testing: exit with error if building docker containers fails ; r=gps

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea11a32f0f61
Backed out changeset 2756877967c1 because autoland went crazy

Comment 5

[Gregory Szorc [:gps]]

wtf autoland.

Comment 6

[Robert Wood [:rwood]]

Attachment: Testing: Exit with error if building docker images fails (bug 1277656;

Review commit: https://reviewboard.mozilla.org/r/60408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60408/

Comment 7

[Robert Wood [:rwood]]

Comment on attachment 8759321 [details]
testing: exit with error if building docker containers fails (bug 1277656);

Pushed to the gecko reviewboard by mistake so couldn't autoland, this is now obsolete

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8764698 [details]
Testing: Exit with error if building docker images fails (bug 1277656;

https://reviewboard.mozilla.org/r/60408/#review57458

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6b188be657a0
Testing: Exit with error if building docker images fails (bug 1277656; r=gps