Closed
Bug 1277852
Opened 9 years ago
Closed 9 years ago
Add config scripts for packaging
Categories
(NSS :: Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: franziskus, Assigned: franziskus)
Details
Attachments
(1 file)
|
3.34 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
We have the request for adding config scripts to NSS for packaging [1].
After recently creating an NSS package for Arch Linux I think this is reasonable and would make life easier for package managers and applications using NSS.
This could look like this [2][3].
[1] https://groups.google.com/forum/#!topic/mozilla.dev.tech.crypto/-X3d-fyTBWw
[2] https://aur.archlinux.org/cgit/aur.git/tree/nss-config.in?h=nss-hg
[3] https://aur.archlinux.org/cgit/aur.git/tree/nss.pc.in?h=nss-hg
Comment 1•9 years ago
|
||
Thank you for the bug report!
[2] looks fine to me.
[3] should have "-L${libdir}" on the Libs: line before the -l arguments, like most other .pc files.
| Assignee | ||
Comment 2•9 years ago
|
||
Kai could you check the config scripts? We should add them to the tree to make packaging easier.
Assignee: nobody → franziskuskiefer
Attachment #8763784 -
Flags: review?(kaie)
Comment 3•9 years ago
|
||
Comment on attachment 8763784 [details] [diff] [review]
config-scripts.patch
the file contents look good, but please don't add it to the toplevel directory.
We already have a ./pkg subdirectory, which seems like the right place.
Comment 4•9 years ago
|
||
r=kaie on the attached patch, if you don't add them to the main directory, but to a new subdirectory ./pkg/pkg-config/
Updated•9 years ago
|
Attachment #8763784 -
Flags: review?(kaie) → review+
| Assignee | ||
Comment 5•9 years ago
|
||
moved the scripts to pkg/pkg-config and landed as
https://hg.mozilla.org/projects/nss/rev/d585f68cd50c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Version: 3.25 → 3.26
| Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → Future
You need to log in
before you can comment on or make changes to this bug.
Description
•