1277853 - fix clang checks in webrtc arm assembly

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nathan Froyd [:froydnj]]

These sort of work, but not for non-iOS platforms.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: adjust checks for clang's integrated assembler in transform_neon.S

This file used __APPLE__ as a shorthand for "compiling with clang's
integrated assembler"; we should really be checking for __clang__ instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/639fda5a2910
adjust checks for clang's integrated assembler in transform_neon.S; r=jesup

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/639fda5a2910

Comment 4

[Maire Reavy [:mreavy]]

Nathan -- Since Fx49 is affected, can you ask for uplift to Fx 49?  Thanks.

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Maire Reavy (On PTO July 23rd to 31st) from comment #4)
> Nathan -- Since Fx49 is affected, can you ask for uplift to Fx 49?  Thanks.

I could, but given that we don't compile with clang on android in fx49, an uplift seems unnecessary.  Does that information change your opinion on whether we need to uplift this?

Comment 6

[Maire Reavy [:mreavy]]

It does change my mind.  I think we're good to let this ride the Fx 50 train.  Thanks for the quick response.