1277854 - Favicons load really slow in home panels

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Scrolling through the home panels in Nightly the favicons load really slowly, one at a time. It's almost 1 sec / icon. This seems to be a new regression.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1277854 - Back out bug 1276050 to ensure we load only local favicons whe requested

(Backed out changeset 9575e608cabe)

loadUncachedFavicon allows loading favicons from the internet, whereas
getSizedFaviconForPageFromLocal restricts itself to the favicon cache.
(LoadFaviconTask's last parameter is (boolean) onlyFromLocal, which is
set to true in getSizedFaviconForPageFromLocal.

We could probably replace this with an Enum to make the parameter's purpose
more obvious.

Review commit: https://reviewboard.mozilla.org/r/57634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57634/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1277854 - Post: add comment explaining local loading

Review commit: https://reviewboard.mozilla.org/r/57636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57636/

Comment 3

[Andrzej Hunt :ahunt]

Regression caused by Bug 1276050.

It's simplest to back it out for now. We could probably clean up favicon loading to make this more obvious, or be more sophisticated and paint the fallback icon initially if we have to download icons from the internet - but that doesn't seem like a good use of time right now.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8759763 [details]
Bug 1277854 - Back out bug 1276050 to ensure we load only local favicons whe requested

https://reviewboard.mozilla.org/r/57634/#review54452

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8759764 [details]
Bug 1277854 - Post: add comment explaining local loading

https://reviewboard.mozilla.org/r/57636/#review54454

Comment 6

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/367c7cce892f627ad7e1f1ceba0f04feb601522a
Bug 1277854 - Back out bug 1276050 to ensure we load only local favicons when requested r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/2086e849a7e6f30fc56100f04847143d6e575ea2
Bug 1277854 - Post: add comment explaining local loading r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/367c7cce892f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2086e849a7e6

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think this backout may need uplifted to 49.

Comment 10

[Andrzej Hunt :ahunt]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #9)
> I think this backout may need uplifted to 49.

I *think* this just made it, although I'm not 100% confiden in my mercurial foo:
https://hg.mozilla.org/releases/mozilla-aurora/rev/367c7cce892f