1277962 - [taskcluster-treeherder] Jobs from some repos put revision_hash in the revision field

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Cameron Dawson [:camd]]

I discovered that some repos like mozilla-beta and mozilla-esr45 have not yet gotten the code to allow tasks to be submitted to Treeherder with a revision.  They only have revision_hash.  So I have a PR in to support submitting a revision_hash.

Once that's merged, please copy the new pulse-job.yml file to taskcluster-treeherder and put revision_hash in when appropriate.

https://github.com/taskcluster/taskcluster-treeherder/blob/eaa7490f49d517688b48b6cd504b3fe2dcbc2e8e/src/util/route_parser.js#L23

Comment 1

[Cameron Dawson [:camd]]

The Treeherder-side support for the revision_hash field are in.  You just need to copy the pulse-job.yml file over and put the revision_hash in the right field now.  

Though, it was also mentioned in bug 1277955 that you may be able to get your changes that fix getting the revision instead of the revision_hash backported into the other repos by the Sheriffs.  I'm not sure how hard that is, tbh.

Also worth mentioning.  I saw several of these revision_hash in the revision field occurrences on mozilla-central today.  I would have expected that only in m-beta and esr45.  But maybe m-c is to be expected, too?

Comment 2

[Cameron Dawson [:camd]]

Attachment: revision_hash_support

Hey Greg--  I took a crack at fixing this.  Does this look about right?