Enable MOZ_ADDON_SIGNING by default in local builds

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

MOZ_ADDON_SIGNING is enabled in automation, lets eliminate this discrepancy between local builds and automation builds.
(Note this just enables signing code, it does not make signing mandatory, that is a separate setting/pref)
Blocks: 1277695
Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

It looks good to me, but I'm not sure why this isn't currently enabled by default.

Dave, do you see any potential problems with this?
Flags: needinfo?(dtownsend)
No, it shouldn't have been removed here: https://hg.mozilla.org/mozilla-central/rev/3f0264791127
Flags: needinfo?(dtownsend)
Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

Great. Thanks
Attachment #8759845 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57684/diff/1-2/
Attachment #8759845 - Flags: review+ → review?(kmaglione+bmo)
I'm not sure why reviewboard cleared the r+ but it wouldn't hurt to take another quick glance, I changed this to effectively revert the relevant bits of the commit that Mossop referenced above.
Attachment #8759845 - Flags: review?(kmaglione+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/f42d06855a0f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.