1277965 - Enable MOZ_ADDON_SIGNING by default in local builds

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Andrew Swan [:aswan]]

MOZ_ADDON_SIGNING is enabled in automation, lets eliminate this discrepancy between local builds and automation builds.
(Note this just enables signing code, it does not make signing mandatory, that is a separate setting/pref)

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1277965 Enable MOZ_ADDON_SIGNING

Review commit: https://reviewboard.mozilla.org/r/57684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57684/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

It looks good to me, but I'm not sure why this isn't currently enabled by default.

Dave, do you see any potential problems with this?

Comment 3

[Dave Townsend [:mossop]]

No, it shouldn't have been removed here: https://hg.mozilla.org/mozilla-central/rev/3f0264791127

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

Great. Thanks

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57684/diff/1-2/

Comment 6

[Andrew Swan [:aswan]]

I'm not sure why reviewboard cleared the r+ but it wouldn't hurt to take another quick glance, I changed this to effectively revert the relevant bits of the commit that Mossop referenced above.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8759845 [details]
Bug 1277965 Enable MOZ_ADDON_SIGNING

https://reviewboard.mozilla.org/r/57684/#review54856

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f42d06855a0f
Enable MOZ_ADDON_SIGNING r=kmag

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f42d06855a0f