Closed Bug 1277965 Opened 5 years ago Closed 5 years ago
_ADDON _SIGNING by default in local builds
MOZ_ADDON_SIGNING is enabled in automation, lets eliminate this discrepancy between local builds and automation builds. (Note this just enables signing code, it does not make signing mandatory, that is a separate setting/pref)
Review commit: https://reviewboard.mozilla.org/r/57684/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57684/
Attachment #8759845 - Flags: review?(kmaglione+bmo)
Comment on attachment 8759845 [details] Bug 1277965 Enable MOZ_ADDON_SIGNING It looks good to me, but I'm not sure why this isn't currently enabled by default. Dave, do you see any potential problems with this?
No, it shouldn't have been removed here: https://hg.mozilla.org/mozilla-central/rev/3f0264791127
Comment on attachment 8759845 [details] Bug 1277965 Enable MOZ_ADDON_SIGNING Great. Thanks
Comment on attachment 8759845 [details] Bug 1277965 Enable MOZ_ADDON_SIGNING Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57684/diff/1-2/
Attachment #8759845 - Flags: review+ → review?(kmaglione+bmo)
I'm not sure why reviewboard cleared the r+ but it wouldn't hurt to take another quick glance, I changed this to effectively revert the relevant bits of the commit that Mossop referenced above.
Comment on attachment 8759845 [details] Bug 1277965 Enable MOZ_ADDON_SIGNING https://reviewboard.mozilla.org/r/57684/#review54856
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f42d06855a0f Enable MOZ_ADDON_SIGNING r=kmag
You need to log in before you can comment on or make changes to this bug.