Closed Bug 1277976 Opened 3 years ago Closed 3 years ago

menu keyboard shortcut Edit -> Calendar Properties conflicts with Edit -> Copy

Categories

(Calendar :: General, defect)

Lightning 4.7.1.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: NotR, Assigned: bv1578)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160502160818

Steps to reproduce:

Alt -> E -> C is a keyboard sequence used for copy in lots of applications, including Thunderbird.


Actual results:

With Lightning installed, there are two different "C" choices, so the user has to read the menu to verify that he's got the right one, and then hit Enter to select it.


Expected results:

Edit -> Calendar Properties should have a different letter selected for its shortcut so it doesn't add steps to  such a common operation.
Attached patch patch - v1Splinter Review
Shouldn't be a problem to backport this until ESR.
Assignee: nobody → bv1578
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8759930 - Flags: review?(philipp)
Attachment #8759930 - Flags: approval-calendar-esr?(philipp)
Attachment #8759930 - Flags: approval-calendar-beta?(philipp)
Attachment #8759930 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8759930 [details] [diff] [review]
patch - v1

Review of attachment 8759930 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! Could you also do a post on m.d.l10n telling localizers that while this isn't a string change, that they should check their own locales to make sure there are no access key conflicts?
Attachment #8759930 - Flags: review?(philipp)
Attachment #8759930 - Flags: review+
Attachment #8759930 - Flags: approval-calendar-esr?(philipp)
Attachment #8759930 - Flags: approval-calendar-esr+
Attachment #8759930 - Flags: approval-calendar-beta?(philipp)
Attachment #8759930 - Flags: approval-calendar-beta+
Attachment #8759930 - Flags: approval-calendar-aurora?(philipp)
Attachment #8759930 - Flags: approval-calendar-aurora+
Pushed to:
http://hg.mozilla.org/releases/comm-aurora/rev/4824916b31f1
http://hg.mozilla.org/releases/comm-beta/rev/f60ef4087aa8
http://hg.mozilla.org/releases/comm-esr45/rev/3593259fac0b

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Could you also do a post on m.d.l10n 

Done.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7.2
You need to log in before you can comment on or make changes to this bug.