1278036 - ./media/gmp-clearkey/0.1/Endian.h shadows /usr/include/endian.h on a case-folding filesystem

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Benoit Girard (:BenWa)]

Same issue as bug 686255. Basically I'm mapping my OSX sourcedir to a linux VM to generate Linux object files using Docker.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Bug 1278036 - Rename Endian.h to BigEndian.h for case insensitive Linux builds.

Review commit: https://reviewboard.mozilla.org/r/57742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57742/

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8759935 [details]
Bug 1278036 - Rename Endian.h to BigEndian.h for case insensitive Linux builds.

Sending review to cpearce.

Also, includes need to be sorted alphabetically after renaming Endian.h to BigEndian.h.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8759935 [details]
Bug 1278036 - Rename Endian.h to BigEndian.h for case insensitive Linux builds.

https://reviewboard.mozilla.org/r/57742/#review54614

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8759935 [details]
Bug 1278036 - Rename Endian.h to BigEndian.h for case insensitive Linux builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57742/diff/1-2/

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 8759935 [details]
Bug 1278036 - Rename Endian.h to BigEndian.h for case insensitive Linux builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57742/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfbdf894eaab
Rename Endian.h to BigEndian.h for case insensitive Linux builds. r=cpearce

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dfbdf894eaab