Closed Bug 1278105 Opened 6 years ago Closed 6 years ago

Update the translations of the "what's new" section

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

As we want to translate the "what's new section" in many different languages, we need to automate for that.
Attachment #8760062 - Flags: review?(jlund)
Assignee: nobody → sledru
Depends on: 1278104
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

https://reviewboard.mozilla.org/r/57786/#review54774

<p>not familiar with this at all but I suspect some will change once https://reviewboard.mozilla.org/r/57782/diff/1#index_header is addressed. resetting r? for now. two nits in the meantime.</p>

::: testing/mozharness/scripts/push_apk.py:179
(Diff revision 1)
>  
> +                locales = self.get_list_locales(package_code)
> +                locales.append(u'en-US')
> +                nb_locales = 0
> +                for locale in locales:
> +                    #                    translation = self.translationMgmt.get_translation(package_code, locale)

can be removed?

::: testing/mozharness/scripts/push_apk.py:180
(Diff revision 1)
> +                locales = self.get_list_locales(package_code)
> +                locales.append(u'en-US')
> +                nb_locales = 0
> +                for locale in locales:
> +                    #                    translation = self.translationMgmt.get_translation(package_code, locale)
> +                    whatsnew = self.translationMgmt.get("whatsnew")

hm, self.translationMgmt is a class. iiuc, .get() is probably not what you want here

::: testing/mozharness/scripts/push_apk.py:190
(Diff revision 1)
> +                             % (locale, whatsnew))
> +
> +                    listing_response = service.edits().apklistings().update(
> +                        editId=edit_id, packageName=self.config['package_name'], language=locale,
> +                        apkVersionCode=apk_response['versionCode'],
> +                        body={'recentChanges': whatsnew}).execute()

unfamiliar with this library but I'll trust you know :)
Attachment #8760062 - Flags: review?(jlund)
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57786/diff/1-2/
Attachment #8760062 - Flags: review?(jlund)
https://reviewboard.mozilla.org/r/57786/#review54774

> can be removed?

It was a typo, we actually need it
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57786/diff/2-3/
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

https://reviewboard.mozilla.org/r/57786/#review56544

looking great. couple nits below. sorry for the delay here, I was a bit distracted from my normal work flow last week :)

::: testing/mozharness/scripts/push_apk.py:179
(Diff revision 3)
>  
> +                locales = self.get_list_locales(package_code)
> +                locales.append(u'en-US')
> +                nb_locales = 0
> +                for locale in locales:
> +                    translation = self.translationMgmt.get_translation(package_code, locale)

hm, still can't see where `translation` is used.

::: testing/mozharness/scripts/push_apk.py:182
(Diff revision 3)
> +                nb_locales = 0
> +                for locale in locales:
> +                    translation = self.translationMgmt.get_translation(package_code, locale)
> +                    whatsnew = self.translationMgmt.get("whatsnew")
> +                    if locale == "en-GB":
> +                        continue

maybe log here we are ignoring en-GB?

::: testing/mozharness/scripts/push_apk.py:206
(Diff revision 3)
> +            track=TRACK,
>              packageName=self.config['package_name'],
> -            body={u'versionCodes': versions}).execute()
> +            body={ u'track': TRACK,
> +                   u'userFraction': USER_FRACTION,
> +                   u'versionCodes': versions}).execute()
> +
>          self.log('Application "%s" set to track "%s" for versions %s' %
>                   (self.config['package_name'], self.config['track'], versions))

in the last log line you use `self.config['track']` but in the .update() call you are passing `TRACK`

do you want to use the static 'production' or `self.config['track']` throughout lines 203-213? Or both and have default be 'production'?
Attachment #8760062 - Flags: review?(jlund) → review-
Blocks: 1281541
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57786/diff/3-4/
Attachment #8760062 - Flags: review- → review?(jlund)
https://reviewboard.mozilla.org/r/57786/#review56544

> hm, still can't see where `translation` is used.

Typo on the next line, fixed (and tested with 48 beta 2)

> in the last log line you use `self.config['track']` but in the .update() call you are passing `TRACK`
> 
> do you want to use the static 'production' or `self.config['track']` throughout lines 203-213? Or both and have default be 'production'?

I will do that in another bug https://bugzilla.mozilla.org/show_bug.cgi?id=1281541
Comment on attachment 8760062 [details]
Bug 1278105 - Update the what's new section in every languages

https://reviewboard.mozilla.org/r/57786/#review57314

lgtm :)
Attachment #8760062 - Flags: review?(jlund) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3df7c89c47d7
Update the what's new section in every languages r=jlund
https://hg.mozilla.org/mozilla-central/rev/3df7c89c47d7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.