1278137 - Use ES6 method syntax in LoginManagerContent.jsm

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Matthew N. [:MattN]]

To modernize the file and add consistency we can use the ES6 method syntax throughout:

> foo: function(a, b) {
becomes
> foo(a, b) {

> foo: function*(a, b) {
becomes
> *foo(a, b) {

Tests can then be run with:
> ./mach test toolkit/components/passwordmgr/

Comment 1

[Saad Quadri [:saadq]]

Attachment: Bug 1278137 - Use ES6 method syntax in LoginManagerContent.jsm.

Review commit: https://reviewboard.mozilla.org/r/58096/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58096/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8760516 [details]
Bug 1278137 - Use ES6 method syntax in LoginManagerContent.jsm.

https://reviewboard.mozilla.org/r/58096/#review54974

Great job!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/756f3d899a78
Use ES6 method syntax in LoginManagerContent.jsm. r=MattN

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/756f3d899a78