Closed Bug 1278137 Opened 3 years ago Closed 3 years ago

Use ES6 method syntax in LoginManagerContent.jsm

Categories

(Toolkit :: Password Manager, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox50 --- fixed

People

(Reporter: MattN, Assigned: saadq, Mentored)

References

()

Details

Attachments

(1 file)

To modernize the file and add consistency we can use the ES6 method syntax throughout:

> foo: function(a, b) {
becomes
> foo(a, b) {

> foo: function*(a, b) {
becomes
> *foo(a, b) {

Tests can then be run with:
> ./mach test toolkit/components/passwordmgr/
Assignee: nobody → saad
Status: NEW → ASSIGNED
Comment on attachment 8760516 [details]
Bug 1278137 - Use ES6 method syntax in LoginManagerContent.jsm.

https://reviewboard.mozilla.org/r/58096/#review54974

Great job!
Attachment #8760516 - Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/fx-team/rev/756f3d899a78
Use ES6 method syntax in LoginManagerContent.jsm. r=MattN
https://hg.mozilla.org/mozilla-central/rev/756f3d899a78
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.