1278164 - [webvtt] Empty Cue's display state when its active flag is unset

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

https://html.spec.whatwg.org/multipage/embedded-content.html#text-track-cue-display-state

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review commit: https://reviewboard.mozilla.org/r/57864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57864/

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1278164 - part2 : modify test.

Review commit: https://reviewboard.mozilla.org/r/57866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57866/

Comment 3

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecce7504436f

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/1-2/

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/1-2/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

https://reviewboard.mozilla.org/r/57866/#review56066

::: dom/media/test/test_webvtt_empty_displaystate.html:59
(Diff revision 2)
> +    cue.onexit = function () {
> +      cue.onexit = null;
> +      checkCueDisplayState(cue, false /* no display-state */);
> +      video.pause();
> +      SimpleTest.finish();
> +    }

It would be nice to keep flags for whether the `onenter` and `onexit` events actually happen. Otherwise the test could silently fail.

Perhaps add a third function which checks the two flags and finishes the test and set it to both `video.onpause` and `video.onended`. That way it should terminate normally after only one more spin of the event loop, but if the Cue events don't happen it will at least finish with an error a few seconds later when seek.webm finishes playback.

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

https://reviewboard.mozilla.org/r/57864/#review56068

Comment 8

[Alastor Wu [:alwu]]

Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/2-3/

Comment 9

[Alastor Wu [:alwu]]

Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/2-3/

Comment 10

[Alastor Wu [:alwu]]

Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Hi, Ralph,
Could you help me review this patch again?
Thanks!

Comment 11

[Ralph Giles (:rillian)]

Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

https://reviewboard.mozilla.org/r/57866/#review56386

That's great. Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d5b3e79015
part1 : empty cue's display state when its active flag is unset r=rillian
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2eb9ae18a37
part2 : modify test. r=rillian

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3d5b3e79015
https://hg.mozilla.org/mozilla-central/rev/b2eb9ae18a37