[webvtt] Empty Cue's display state when its active flag is unset

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

(Blocks: 1 bug)

Other Branch
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

https://html.spec.whatwg.org/multipage/embedded-content.html#text-track-cue-display-state
Created attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review commit: https://reviewboard.mozilla.org/r/57864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57864/
Created attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Review commit: https://reviewboard.mozilla.org/r/57866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57866/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecce7504436f
Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/1-2/
Attachment #8760189 - Attachment description: Bug 1278164 - part1 : empty Cue's display state when its active flag is unset → Bug 1278164 - part1 : empty cue's display state when its active flag is unset
Attachment #8760189 - Flags: review?(giles)
Attachment #8760190 - Flags: review?(giles)
Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/1-2/
Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

https://reviewboard.mozilla.org/r/57866/#review56066

::: dom/media/test/test_webvtt_empty_displaystate.html:59
(Diff revision 2)
> +    cue.onexit = function () {
> +      cue.onexit = null;
> +      checkCueDisplayState(cue, false /* no display-state */);
> +      video.pause();
> +      SimpleTest.finish();
> +    }

It would be nice to keep flags for whether the `onenter` and `onexit` events actually happen. Otherwise the test could silently fail.

Perhaps add a third function which checks the two flags and finishes the test and set it to both `video.onpause` and `video.onended`. That way it should terminate normally after only one more spin of the event loop, but if the Cue events don't happen it will at least finish with an error a few seconds later when seek.webm finishes playback.
Attachment #8760190 - Flags: review?(giles) → review+
Attachment #8760189 - Flags: review?(giles) → review+
Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

https://reviewboard.mozilla.org/r/57864/#review56068
Comment on attachment 8760189 [details]
Bug 1278164 - part1 : empty cue's display state when its active flag is unset

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/2-3/
Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/2-3/
Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

Hi, Ralph,
Could you help me review this patch again?
Thanks!
Attachment #8760190 - Flags: review+ → review?(giles)
Comment on attachment 8760190 [details]
Bug 1278164 - part2 : modify test.

https://reviewboard.mozilla.org/r/57866/#review56386

That's great. Thanks!
Attachment #8760190 - Flags: review?(giles) → review+

Comment 12

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d5b3e79015
part1 : empty cue's display state when its active flag is unset r=rillian
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2eb9ae18a37
part2 : modify test. r=rillian

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f3d5b3e79015
https://hg.mozilla.org/mozilla-central/rev/b2eb9ae18a37
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.