Closed
Bug 1278164
Opened 8 years ago
Closed 8 years ago
[webvtt] Empty Cue's display state when its active flag is unset
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57864/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57864/
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/57866/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57866/
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecce7504436f
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8760189 [details] Bug 1278164 - part1 : empty cue's display state when its active flag is unset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/1-2/
Attachment #8760189 -
Attachment description: Bug 1278164 - part1 : empty Cue's display state when its active flag is unset → Bug 1278164 - part1 : empty cue's display state when its active flag is unset
Attachment #8760189 -
Flags: review?(giles)
Attachment #8760190 -
Flags: review?(giles)
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8760190 [details] Bug 1278164 - part2 : modify test. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/1-2/
Comment 6•8 years ago
|
||
Comment on attachment 8760190 [details] Bug 1278164 - part2 : modify test. https://reviewboard.mozilla.org/r/57866/#review56066 ::: dom/media/test/test_webvtt_empty_displaystate.html:59 (Diff revision 2) > + cue.onexit = function () { > + cue.onexit = null; > + checkCueDisplayState(cue, false /* no display-state */); > + video.pause(); > + SimpleTest.finish(); > + } It would be nice to keep flags for whether the `onenter` and `onexit` events actually happen. Otherwise the test could silently fail. Perhaps add a third function which checks the two flags and finishes the test and set it to both `video.onpause` and `video.onended`. That way it should terminate normally after only one more spin of the event loop, but if the Cue events don't happen it will at least finish with an error a few seconds later when seek.webm finishes playback.
Attachment #8760190 -
Flags: review?(giles) → review+
Updated•8 years ago
|
Attachment #8760189 -
Flags: review?(giles) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8760189 [details] Bug 1278164 - part1 : empty cue's display state when its active flag is unset https://reviewboard.mozilla.org/r/57864/#review56068
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8760189 [details] Bug 1278164 - part1 : empty cue's display state when its active flag is unset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57864/diff/2-3/
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8760190 [details] Bug 1278164 - part2 : modify test. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57866/diff/2-3/
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8760190 [details] Bug 1278164 - part2 : modify test. Hi, Ralph, Could you help me review this patch again? Thanks!
Attachment #8760190 -
Flags: review+ → review?(giles)
Comment 11•8 years ago
|
||
Comment on attachment 8760190 [details] Bug 1278164 - part2 : modify test. https://reviewboard.mozilla.org/r/57866/#review56386 That's great. Thanks!
Attachment #8760190 -
Flags: review?(giles) → review+
Comment 12•8 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d5b3e79015 part1 : empty cue's display state when its active flag is unset r=rillian https://hg.mozilla.org/integration/mozilla-inbound/rev/b2eb9ae18a37 part2 : modify test. r=rillian
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f3d5b3e79015 https://hg.mozilla.org/mozilla-central/rev/b2eb9ae18a37
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•