1278214 - [Static Analysis][Result is not floating-point] In function ComputeSpacedRepeatSize

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that the result of the following operation is not floating point:

>>  float ratio = aAvailableSpace / aImageDimension;

This is only when  NS_COORD_IS_FLOAT is not defined.

I think the correct method should be:

>>#ifdef NS_COORD_IS_FLOAT
>>  float ratio = aAvailableSpace / aImageDimension;
>>#else
>>  float ratio = static_cast<float>(aAvailableSpace) / aImageDimension;
>>#endif

Comment 1

[Andi [:andi]]

Attachment: Bug 1278214 - ensure operation result is floating point.

Review commit: https://reviewboard.mozilla.org/r/57890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57890/

Comment 2

[Mats Palmgren (inactive)]

I don't think the #ifdef is needed, just use:
  float ratio = static_cast<float>(aAvailableSpace) / aImageDimension;
it will work for both cases.

Comment 3

[Andi [:andi]]

sure it will work for both cases, but when nscoord is defined as float do we really want to do the static_cast? In this case is useless. That's why i've used the ifdef. But if you still think i should change it i will update the patch.

Comment 4

[Mats Palmgren (inactive)]

It's unlikely that we will ever enable NS_COORD_IS_FLOAT so we should try
to avoid introducing new uses of it when it can be avoided.  I think
the one-liner is the preferred way for cases like this.

Comment 5

[Andi [:andi]]

Comment on attachment 8760233 [details]
Bug 1278214 - ensure operation result is floating point.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57890/diff/1-2/

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8760233 [details]
Bug 1278214 - ensure operation result is floating point.

https://reviewboard.mozilla.org/r/57890/#review54754

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffe52673664f
ensure operation result is floating point. r=mats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ffe52673664f