1278251 - [Static Analysis][Assign instead of compare] In function CodeGeneratorX64::loadSimd

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that an assignment operation is performed instead of comparison:


>>      case Scalar::Int8x16:
>>        MOZ_ASSERT(numElems = 16, "unexpected partial load");
>>        masm.loadUnalignedSimd128Int(srcAddr, out);
>>        break;
>>      case Scalar::Int16x8:
>>        MOZ_ASSERT(numElems = 8, "unexpected partial load");
>>        masm.loadUnalignedSimd128Int(srcAddr, out);
>>        break; 

In this way the two assertion become useless.

Comment 1

[Andi [:andi]]

Attachment: Bug 1278251 - corrected assign instead of compare.

Review commit: https://reviewboard.mozilla.org/r/57912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57912/

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8760272 [details]
Bug 1278251 - corrected assign instead of compare.

https://reviewboard.mozilla.org/r/57912/#review54772

Stealing as it's trivial. Thanks for the fix.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c089327950e6
corrected assign instead of compare. r=bbouvier

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c089327950e6