1278255 - Action in media notification always has title "Pause"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

In bug 1264901 I always use "pause" as title for the media action:
> String title = getString(isPlayAction ? R.string.media_pause : R.string.media_pause);

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1278255 - MediaControlService: Set correct action title.

Review commit: https://reviewboard.mozilla.org/r/57932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57932/

Comment 2

[Andrzej Hunt :ahunt]

Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

https://reviewboard.mozilla.org/r/57932/#review54766

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/c4ad6175835899aac9ca58eaf40ff77853b20823
Bug 1278255 - MediaControlService: Set correct action title. r=ahunt

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

After bug 1264901 this needs to be uplifted too.

Approval Request Comment
[Feature/regressing bug #]: bug 1264901 
[User impact if declined]: Wrong action title used in notification ("Pause" instead of "Play").
[Describe test coverage new/current, TreeHerder]: Local testing
[Risks and why]: Very low - just replacing the label.
[String/UUID change made/needed]: None, string already exists.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4ad61758358

Comment 6

[Sorina Florean [:sflorean]]

Verified as fixed in build 50.0a1 (2016-06-10);
Device: Nexus 5 (Android 6.0.1).

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

Minor fix for notification name. Should uplift after bug 1264901.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d4729051985

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed in build 49.0a2 (2016-07-17);
Device: LG G4 (Android 5.1).