Closed Bug 1278255 Opened 3 years ago Closed 3 years ago

Action in media notification always has title "Pause"

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 50
Tracking Status
firefox49 --- verified
firefox50 --- verified

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

In bug 1264901 I always use "pause" as title for the media action:
> String title = getString(isPlayAction ? R.string.media_pause : R.string.media_pause);
Attachment #8760288 - Flags: review?(ahunt) → review+
Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

https://reviewboard.mozilla.org/r/57932/#review54766
Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

After bug 1264901 this needs to be uplifted too.

Approval Request Comment
[Feature/regressing bug #]: bug 1264901 
[User impact if declined]: Wrong action title used in notification ("Pause" instead of "Play").
[Describe test coverage new/current, TreeHerder]: Local testing
[Risks and why]: Very low - just replacing the label.
[String/UUID change made/needed]: None, string already exists.
Attachment #8760288 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c4ad61758358
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Verified as fixed in build 50.0a1 (2016-06-10);
Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Comment on attachment 8760288 [details]
Bug 1278255 - MediaControlService: Set correct action title.

Minor fix for notification name. Should uplift after bug 1264901.
Attachment #8760288 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in build 49.0a2 (2016-07-17);
Device: LG G4 (Android 5.1).
You need to log in before you can comment on or make changes to this bug.