Closed Bug 1278306 Opened 3 years ago Closed 3 years ago

Remove all uses of 'content.location = ' in the webconsole tests

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
e10s + ---
firefox48 --- fixed
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: bgrins, Assigned: moby)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Let's just take care of a bunch of these CPOWs in one patch.  We shouldn't be using content.location = foo anymore, and should instead use BrowserTestUtils.loadURI(gBrowser.selectedBrowser, foo);
Moby, can you take a look at this one for the webconsole test directory?
Flags: needinfo?(mvonbriesen)
Priority: -- → P1
Version: 46 Branch → Trunk
Assignee: nobody → mvonbriesen
Flags: needinfo?(mvonbriesen)
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Moby, can you take a look at this one for the webconsole test directory?

Sure
Attachment #8760428 - Flags: review?(bgrinstead)
Comment on attachment 8760428 [details] [diff] [review]
remove-content-location.patch

Review of attachment 8760428 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - this should prevent a bunch of intermittents on e10s.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb37e25bb2c3
Attachment #8760428 - Flags: review?(bgrinstead) → review+
tracking-e10s: --- → ?
Keywords: checkin-needed
Status: NEW → ASSIGNED
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/54354d5ade58
Remove all uses of 'content.location = ' in the webconsole tests; r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/54354d5ade58
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.