Remove all uses of 'content.location = ' in the webconsole tests

RESOLVED FIXED in Firefox 48

Status

P1
normal
RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: bgrins, Assigned: moby)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 50
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox48 fixed, firefox49 fixed, firefox50 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Let's just take care of a bunch of these CPOWs in one patch.  We shouldn't be using content.location = foo anymore, and should instead use BrowserTestUtils.loadURI(gBrowser.selectedBrowser, foo);
(Reporter)

Comment 1

3 years ago
Moby, can you take a look at this one for the webconsole test directory?
Flags: needinfo?(mvonbriesen)
Priority: -- → P1
Version: 46 Branch → Trunk
(Assignee)

Updated

3 years ago
Assignee: nobody → mvonbriesen
Flags: needinfo?(mvonbriesen)
(Assignee)

Comment 2

3 years ago
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Moby, can you take a look at this one for the webconsole test directory?

Sure
(Assignee)

Comment 3

3 years ago
Created attachment 8760428 [details] [diff] [review]
remove-content-location.patch
Attachment #8760428 - Flags: review?(bgrinstead)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8760428 [details] [diff] [review]
remove-content-location.patch

Review of attachment 8760428 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - this should prevent a bunch of intermittents on e10s.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb37e25bb2c3
Attachment #8760428 - Flags: review?(bgrinstead) → review+

Updated

3 years ago
tracking-e10s: --- → ?
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Blocks: 984139
tracking-e10s: ? → +
(Reporter)

Updated

3 years ago
Status: NEW → ASSIGNED

Comment 5

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/54354d5ade58
Remove all uses of 'content.location = ' in the webconsole tests; r=bgrins
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/54354d5ade58
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.