1278310 - Use @@toStringTag rather than Debugger.Object.prototype.class for object previews

Status: RESOLVED DUPLICATE of bug 1526688

(DevTools :: Debugger, enhancement, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Of course, we should only run safe, native/DOM @@toStringTag methods, not debuggee provided methods. In the latter case, we should fallback to something else (it isn't clear to me whether Debugger.Object.prototype.class should still exist at all...)

Comment 1

[Eddy Bruel [:ejpbruel]]

Just so I'm clear: @@toStringTag is an ES6 thing, intended to replace the [[Class]] internal property. Is that correct?

This is an improvement, but there's not immediate urgency to implement it. Marking this as P2.

Comment 2

[Jason Laster [:jlast]]

Brian what do you think about this?

Comment 3

[Brian Hackett [Laid off!]]

I guess my first reaction is that it would be neat if we could run debuggee provided toString methods. The problem reminds me of something we discussed at the workweek where we could attempt to run debuggee code and bail out if there are side effects, e.g. to support auto-complete / related features when evaluating things in the console. If we had a way to do this then we could also call debuggee toString() methods in object previews, bailing out if they start doing something crazy.